Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't translate the editor-provided Devfile commands to VS Code Tasks #22098

Closed
azatsarynnyy opened this issue Mar 24, 2023 · 0 comments · Fixed by che-incubator/che-code#192
Closed

Don't translate the editor-provided Devfile commands to VS Code Tasks #22098

azatsarynnyy opened this issue Mar 24, 2023 · 0 comments · Fixed by che-incubator/che-code#192
Assignees
@azatsarynnyy
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.64

Comments

@azatsarynnyy
Copy link
Member

Is your enhancement related to a problem? Please describe

I noticed one small side-effect of adding the command of exec type in the editor definition:
Now, it's listed among all the VS Code Tasks of the devfile type:
image

This command is needed just for running the VS Code. It's useless for the user, as a VS Code Task.

Describe the solution you'd like

The solution can be filtering out the exec Devfile commands provided by the editor definition.
We can filter them by the controller.devfile.io/imported-by: editor attribute in the flattened Devfile.

Describe alternatives you've considered

No response

Additional context

#21879 (comment)
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/editor/vscode Issues related to the Code OSS editor of Che labels Mar 24, 2023
@azatsarynnyy azatsarynnyy added this to the 7.64 milestone Mar 24, 2023
@azatsarynnyy azatsarynnyy mentioned this issue Mar 24, 2023
Merged
@azatsarynnyy azatsarynnyy self-assigned this Mar 24, 2023
@azatsarynnyy azatsarynnyy mentioned this issue Mar 28, 2023
Merged
@AObuchow AObuchow mentioned this issue Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.64
Development

Successfully merging a pull request may close this issue.

fix: Filter out the editor-provided commands che-incubator/che-code
1 participant
@azatsarynnyy