Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional annotation for disableSubdomainIsolation config #21986

Closed
Tracked by #21941
vinokurig opened this issue Feb 6, 2023 · 6 comments
Closed
Tracked by #21941

Add an optional annotation for disableSubdomainIsolation config #21986

vinokurig opened this issue Feb 6, 2023 · 6 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/doc Issues related to documentation area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next
Milestone

Comments

@vinokurig
Copy link
Contributor

Is your enhancement related to a problem? Please describe

There is an ability to configure OAuth for Github Enterprise server without subdomain isolation added by #21724 :

spec:
  gitServices:
    github:
      - endpoint: 'https://github.com'
        secretName: github-oauth-config
        disableSubdomainIsolation: true

It would be great to have the similar configuration via the oauth secret annotations.

Describe the solution you'd like

Add an optional annotation field to the github oauth secret config e.g.

  annotations:
    che.eclipse.org/oauth-scm-server: github
    che.eclipse.org/scm-server-endpoint: <github_server_url>
    che.eclipse.org/scm-github-disableSubdomainIsolation: <true/false>

Describe alternatives you've considered

No response

Additional context

See #21964

@vinokurig vinokurig added kind/enhancement A feature request - must adhere to the feature request template. area/che-server area/factory/server Server side of factory implementation area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts labels Feb 6, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 6, 2023
@tolusha
Copy link
Contributor

tolusha commented Feb 6, 2023

What about che.eclipse.org/scm-disable-subdomain-isolation

@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 6, 2023
@vinokurig
Copy link
Contributor Author

What about che.eclipse.org/scm-disable-subdomain-isolation

This is a GitHub server specific property so I think we should keep github in it's name

@tolusha tolusha added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/doc Issues related to documentation and removed area/che-server area/factory/server Server side of factory implementation labels Feb 7, 2023
@tolusha
Copy link
Contributor

tolusha commented Feb 7, 2023

Agreed, so che.eclipse.org/scm-github-disable-subdomain-isolation

@tolusha
Copy link
Contributor

tolusha commented Feb 7, 2023

@l0rd What do you think?

@l0rd
Copy link
Contributor

l0rd commented Feb 7, 2023

That works for me

@l0rd
Copy link
Contributor

l0rd commented Feb 7, 2023

@tolusha we should remove endpoint and disableSubdomainIsolation from CheCluster spec.gitServices too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/doc Issues related to documentation area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/next
Projects
None yet
Development

No branches or pull requests

5 participants