Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions fail for Che-Code on the downloading ripgrep step #21982

Closed
RomanNikitenko opened this issue Feb 2, 2023 · 6 comments · Fixed by che-incubator/che-code#170
Closed
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Feb 2, 2023

Describe the bug

Github actions fail for Che-Code on the downloading ripgrep

Che version

7.60@latest

Steps to reproduce

See here, for example.

Expected behavior

Github actions pass successfully.

Screenshots

image

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 2, 2023
@RomanNikitenko RomanNikitenko changed the title Github actions fails for Che-Code on the downloading ripgrep Github actions fail for Che-Code on the downloading ripgrep Feb 2, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 2, 2023
@RomanNikitenko RomanNikitenko changed the title Github actions fail for Che-Code on the downloading ripgrep Github actions fail for Che-Code on the downloading ripgrep step Feb 2, 2023
@azatsarynnyy azatsarynnyy added severity/P1 Has a major impact to usage or development of the system. area/editor/vscode Issues related to the Code OSS editor of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. area/editors labels Feb 2, 2023
@azatsarynnyy azatsarynnyy self-assigned this Feb 2, 2023
@azatsarynnyy
Copy link
Member

@azatsarynnyy
Copy link
Member

Since the fix is merged 100% of all builds are completed successfully on the first try 🎉

@RomanNikitenko
Copy link
Member Author

Unfortunately I've faced with the same problem again: https://github.com/che-incubator/che-code/actions/runs/4102911504/jobs/7076459122

image

@azatsarynnyy
Copy link
Member

I think it's expected, as the job is run against the fork https://github.com/RomanNikitenko/che-code/tree/restartWorkspaceAction
and

...workflows from forks do not have access to sensitive data such as secrets...

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@azatsarynnyy
Copy link
Member

Anyway, it would be nice to investigate how to fix it for the jobs running on the PRs opened from the forks.
@RomanNikitenko if you can file a low-priority issue for such case that would be great.

@azatsarynnyy
Copy link
Member

I see a few more jobs where setting the GITHUB_TOKEN should solve the Request failed: 403 problem.
Provied che-incubator/che-code#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants