Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: devfilev2 and master branch cleanup in che-samples repos #21926

Closed
4 of 5 tasks
Tracked by #21941 ...
nickboldt opened this issue Jan 9, 2023 · 1 comment
Closed
4 of 5 tasks
Tracked by #21941 ...
Assignees
Labels
area/devfile-registry area/samples kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Milestone

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jan 9, 2023

Is your task related to a problem? Please describe

Today the che-samples repos have both a CURRENT, maintained devfilev2 branch, and a default master or main branch:

https://github.com/che-samples/web-php-simple
https://github.com/che-samples/web-nodejs-sample
... (others)

Describe the solution you'd like

Since devfile v1 is no longer the default / no longer really supported... should we:

Or do the sample projects all get migrated to devfile.io?

@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 9, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 9, 2023
@nickboldt nickboldt changed the title Should we force-merge the devfilev2 branches of the che samples into its main branch? Tech debt: devfilev2 and master branch cleanup in che-samples repos Jan 9, 2023
@ibuziuk ibuziuk mentioned this issue Jan 9, 2023
60 tasks
@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 9, 2023
@svor
Copy link
Contributor

svor commented Jan 9, 2023

Default branch in che-samples repositories contain devfile v1 and I don't think we use it in any place. Since we completely switched to devfile v2, I'd combine and apply these two options:

force-push the contents of the devfilev2 branches into main
if the project doesn't have a main branch (only an obsolete master branch), simply rename devfilev2 to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry area/samples kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

4 participants