Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a checkoutFrom.revision url parameter for factoryUrl #21922

Closed
Tracked by #21925
dkwon17 opened this issue Jan 6, 2023 · 1 comment
Closed
Tracked by #21925

Provide a checkoutFrom.revision url parameter for factoryUrl #21922

dkwon17 opened this issue Jan 6, 2023 · 1 comment
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Jan 6, 2023

Is your enhancement related to a problem? Please describe

This enhancement is an alternative to #21921

When creating a workspace with a factory url with a branch:

{CHE-HOST}/#https://github.com/eclipse-che/che-plugin-registry/tree/7.59.x

The checkoutFrom.revision for the resulting DW is 7.59.x, meaning, when opening the workspace, the branch that is checked out is 7.59.x:

projects:
  - git:
      checkoutFrom:
        revision: 7.59.x
      remotes:
        origin: 'https://github.com/eclipse-che/che-plugin-registry'
    name: che-plugin-registry

But, if we take the url above and configure remotes on top of it, by setting origin to https://github.com/dkwon17/che-plugin-registry and upstream to https://github.com/eclipse-che/che-plugin-registry:

{CHE-HOST}/#https://github.com/eclipse-che/che-plugin-registry/tree/7.59.x?remotes={{origin,https://github.com/dkwon17/che-plugin-registry},{upstream,https://github.com/eclipse-che/che-plugin-registry}}

The checkoutFrom.revision is not set in this case, because there is no guarantee that the 7.59.x branch exists in the newly configured origin remote:

projects:
  - git:
      checkoutFrom:
        remote: origin
      remotes:
        origin: 'https://github.com/dkwon17/che-plugin-registry'
        upstream: 'https://github.com/eclipse-che/che-plugin-registry'
    name: che-plugin-registry

Therefore, it would be great to have some way to configure the checkoutFrom.revision field when specifying remotes.

Describe the solution you'd like

Have checkoutFrom.revision configurable with a url parameter

Describe alternatives you've considered

#21921

Additional context

This feature is helpful for redhat-actions/try-in-web-ide#14, since it would help the GitHub action to set up remotes as well as set up the checkoutFrom.revision branch.

@dkwon17 dkwon17 added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. area/dashboard sprint/next labels Jan 6, 2023
@dkwon17 dkwon17 changed the title Provide a checkoutFrom url parameter for factoryUrl Provide a checkoutFrom.revision url parameter for factoryUrl Jan 9, 2023
@dkwon17 dkwon17 mentioned this issue Jan 9, 2023
60 tasks
@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2023
@che-bot che-bot closed this as completed Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants