Che Operator should not install Image Puller Operator and update Eclipse Che CR with the list of images

[ibuziuk]

Is your enhancement related to a problem? Please describe

Currently, the Eclipse Che operator would install the Image Puller operator if the CR property is set accordingly:

imagePuller:
      enable: true

What is more, once the operator is installed and image puller CR is created Eclipse Che CR's spec would be updated with the list of images and look the following way:

imagePuller:
      enable: true
      spec:
        images: >-
          devspaces-code-devfile-registry-image-gmxdgcq=registry.redhat.io/devspaces/code-rhel8@sha256:d5efb27645f7ed12d449e8c35f01070b2fb6d247d79c94f374d8781371a17318;devspaces-code-plugin-registry-image-gmxdgcq=registry.redhat.io/devspaces/code-rhel8@sha256:d5efb27645f7ed12d449e8c35f01070b2fb6d247d79c94f374d8781371a17318;devspaces-idea-devfile-registry-image-gmxdgcq=registry.redhat.io/devspaces/idea-rhel8@sha256:49ecbcf1c6507057822c1aa3b901724f05551264913eb303dec8ec3273b096ba;devspaces-idea-plugin-registry-image-gmxdgcq=registry.redhat.io/devspaces/idea-rhel8@sha256:49ecbcf1c6507057822c1aa3b901724f05551264913eb303dec8ec3273b096ba;devspaces-machineexec-plugin-registry-image-gmxdgcq=registry.redhat.io/devspaces/machineexec-rhel8@sha256:f849e92075ccb720ea211691d379a381fdb158c25e083a219a711278d3614981;devspaces-theia-devfile-registry-image-gmxdgcq=registry.redhat.io/devspaces/theia-rhel8@sha256:cc2719d356069f7e8a2a55e688096872793d84f30c8d577e1e24aa3002132948;devspaces-theia-endpoint-devfile-registry-image-gmxdgcq=registry.redhat.io/devspaces/theia-endpoint-rhel8@sha256:2d927b80a8f7cc9df7313e2b137559a797ecb82ef114bea16efae1d087a32254;devspaces-theia-endpoint-plugin-registry-image-gmxdgcq=registry.redhat.io/devspaces/theia-endpoint-rhel8@sha256:2d927b80a8f7cc9df7313e2b137559a797ecb82ef114bea16efae1d087a32254;devspaces-theia-plugin-registry-image-gmxdgcq=registry.redhat.io/devspaces/theia-rhel8@sha256:cc2719d356069f7e8a2a55e688096872793d84f30c8d577e1e24aa3002132948;

Current behaviour could be treated as a bad design due to the following reasons:

• Eclipse Che operator should not install and onboard a new operator (image puller) under the hood
• Original Eclipse Che CR should not be updated with the image list for pre-pulling since this is irrelevant info

Describe the solution you'd like

• When imagePuller is enabled Che Operator just creates a CR for image puller, but does not install the operator. If the Image Puller operator is not installed on the cluster the error message is shown with the instruction for admin e.g. "Image Puller Operator is not installed, in order to enable the property admin should install the operator first"
• Eclipse Che CR is not updated with values (image list) when image puller is enabled. The only thing that Eclipse Che Operator does is creation of the CR for image-puller with the list of images retrieved from csv.
• When imagePuller is disabled only related CR is deleted - Image Puller operator is not uninstalled

Describe alternatives you've considered

No response

Additional context

No response

[tolusha]

What will happen, if a user update ImagePuller spec in CheCluster CR?