Not possible to limit the number of workspaces per user

[ibuziuk]

Describe the bug

spec:
  components:
    cheServer:
      extraProperties:
        CHE_LIMITS_USER_WORKSPACES_COUNT: "<kept_workspaces_limit>" 

configuration does not work

Che version

7.57@latest

Steps to reproduce

Follow the docs for Limiting the number of workspaces that a user can keep https://www.eclipse.org/che/docs/stable/administration-guide/limiting-the-number-of-workspaces-that-a-user-can-keep/

ERROR: the procedure does not work, user can create unlimited number of workspaces

Expected behavior

Introduce new CR property, since it is not expected to configure the limit of DevWorkspace using che-server extraProperties

devWorkspace:
totalLimitPerUser: '5'
runningLimit: '2'

In general, I believe we need to consider deprecation and removal of the DevWorksace field from the CR and have the workspace limits configured in DevEnvironments

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

No response

Additional context

Outdated docs - https://www.eclipse.org/che/docs/stable/administration-guide/limiting-the-number-of-workspaces-that-a-user-can-keep/

In general, I believe we need to consider deprecation and removal of the DevWorksace field from the CR and have the workspace limits configured in DevEnvironments

Release Notes Text

Title: The maximum number of running workspace per user is configurable
A new CheCluster parameter allows administrators to specify the maximum number or running workspaces per user. It can be configured editing the value spec.devEnvironments.maxNumberOfRunningWorkspacesPerUser of CheCluster custom resource.

[l0rd]

We need to update the doc

[tolusha]

The doc was updated in this PR
eclipse-che/che-docs#2538

[l0rd]

@tolusha sorry about that, we were looking at the wrong version of the doc

[devstudio-release]

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3870

• feat: limit the number of workspaces per user che-operator#1585
• chore: Respect spec.devEnvironments.maxNumberOfRunningWorkspacesPerUs… che-dashboard#703
• fix: articles regarding the number of workspaces that use can run and… che-docs#2538
• feat: Limit number of workspaces per user che-dashboard#707

[dmytro-ndp]

@ibuziuk : I was able to create 5 workspaces in DS 3.5.0.RC-03-10 having CHE_LIMITS_USER_WORKSPACES_COUNT: '3' in CheCluster config:

spec:
  components:
    devWorkspace:
      runningLimit: '2'
    cheServer:
      debug: false
      logLevel: INFO
      extraProperties:
        CHE_LIMITS_USER_WORKSPACES_COUNT: '3'

[l0rd]

@dmytro-ndp this is not the right field. Please refer to the doc

[dmytro-ndp]

@l0rd: thanks for the hint.
It worked as expected in DS 3.5.0.RC-03-10 following the article you shared:

spec:
  devEnvironments:
    maxNumberOfWorkspacesPerUser: 3
    maxNumberOfRunningWorkspacesPerUser: 2