Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better naming of VS Code Task Type for the Devfile Commands #21840

Closed
Tracked by #21864
, #21925
...
azatsarynnyy opened this issue Nov 25, 2022 · 1 comment · Fixed by che-incubator/che-code#167
Closed
Tracked by #21864
, #21925
...

Better naming of VS Code Task Type for the Devfile Commands #21840

azatsarynnyy opened this issue Nov 25, 2022 · 1 comment · Fixed by che-incubator/che-code#167
Assignees
@azatsarynnyy
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.60

Comments

@azatsarynnyy
Copy link
Member

Is your enhancement related to a problem? Please describe

In VS Code, we use a dedicated Task Type che for all the Devfile Commands translated to VS Code Tasks:
image

One of the problems with the name is that when it's downstreamed, it's not possible to rename that Task Type to override the upstream naming.

Describe the solution you'd like

Use the Task Type name that would:

  • better reflect the source of such VS Code Tasks;
  • be more neutral and better appropriate when downstreaming.

I think the devfile name sounds good for such purposes.

Describe alternatives you've considered

No response

Additional context

No response
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che sprint/next labels Nov 25, 2022
@azatsarynnyy
Copy link
Member Author

The downstream issue: https://issues.redhat.com/browse/CRW-3333

@azatsarynnyy azatsarynnyy mentioned this issue Dec 8, 2022
Closed
82 tasks
@azatsarynnyy azatsarynnyy added this to the 7.59 milestone Dec 13, 2022
@l0rd l0rd modified the milestones: 7.59, 7.60 Jan 5, 2023
@azatsarynnyy azatsarynnyy mentioned this issue Jan 10, 2023
Closed
60 tasks
@azatsarynnyy azatsarynnyy removed this from the 7.60 milestone Jan 10, 2023
@azatsarynnyy azatsarynnyy added this to the 7.60 milestone Jan 10, 2023
@azatsarynnyy azatsarynnyy mentioned this issue Jan 24, 2023
Merged
@azatsarynnyy azatsarynnyy self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.60
Development

Successfully merging a pull request may close this issue.

Rename the Task Group: che > devfile che-incubator/che-code
4 participants
@nickboldt @l0rd @ibuziuk @azatsarynnyy