Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check OAuth tokens validity when workspace restarts #21640

Closed
Tracked by #21705
, #21745
...
l0rd opened this issue Aug 18, 2022 · 1 comment
Closed
Tracked by #21705
, #21745
...

Check OAuth tokens validity when workspace restarts #21640

l0rd opened this issue Aug 18, 2022 · 1 comment
Assignees
@vinokurig
Labels
area/che-server area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.56

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 18, 2022 •
edited
Loading

Is your enhancement related to a problem? Please describe

The validity of the GitHub/Bitbucket/Gitlab personal access tokens (that Che generates and stores as a secret in a developer namespace) are checked only when a workspace is started for the first time.

If the token expires and an existing workspace is restarted the developer won't be able to use the git service.

Describe the solution you'd like

Check if the token is valid at workspace startup (it would be useful if a message mentioning that a token was found and is being verified is logged in the dashboard workspace startup progress page).

If the token is invalid generate a new one as it's done when a workspace is started for the first time.

Additional context

#21291
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/che-server area/dashboard area/git labels Aug 18, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 18, 2022
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 18, 2022
@l0rd l0rd mentioned this issue Aug 18, 2022
Open
@vinokurig vinokurig self-assigned this Aug 19, 2022
@svor svor mentioned this issue Aug 25, 2022
Closed
82 tasks
@vinokurig vinokurig mentioned this issue Sep 16, 2022
Merged
9 tasks
@svor svor mentioned this issue Sep 19, 2022
Closed
59 tasks
This was referenced Sep 23, 2022
Merged
Merged
@svor svor mentioned this issue Oct 11, 2022
Closed
67 tasks
@vinokurig
Copy link
Contributor

is fixed by
eclipse-che/che-server#356
eclipse-che/che-server#359
eclipse-che/che-dashboard#640

@svor svor added this to the 7.56 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/che-server area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.56
Development

No branches or pull requests
5 participants
@l0rd @svor @ibuziuk @vinokurig @che-bot