-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code for Eclipse Che works with both UBI 8 and 9 #21629
Comments
on ubi9 there are different libcrypto versions
|
so maybe copying nodejs binary from |
In order for this to work downstream we would need to start from https://catalog.redhat.com/software/containers/ubi9/nodejs-16/61a60604c17162a20c1c6a2e or https://catalog.redhat.com/software/containers/ubi9/ubi-minimal/615bd9b4075b022acc111bf5 and adjust the image as needed. |
@nickboldt are you sure? This is not about using UBI 9 image for UDI (or for VS Code). This is to allow a user to specify an UBI 9 based custom image in a devfile and VS Code as an editor. |
@l0rd @benoitf we're going to apply the solution proposed in che-incubator/che-code#120. See more details in the comment. It's simple and allows to work around the original problem while we're not migrated to UBI9. |
I would have added a nodejs ubi9 binary in the image and pick-up at runtime the correct nodejs binary. if ssl 1.1, pick-up nodejs from ubi8 else if ssl 3, use nodejs from ubi9 (we already have a nodejs for alpine and another one for ubi8) Also the active nodejs LTS version will be switched to nodejs 18 at the end of this month (and since nodejs17, openssl to use is v3) so more and more people will expect to have openssl 3 |
hello, Florent! Agree, it would be good solution and I tried it some time ago. I guess the problem is:
A possible solution is: a user who is using the UBI 9 based custom image as UDI should provide two things:
On the
I commented about it 5 days ago in another issue (Artem posted the corresponding link above, but you should be logged in). |
Downstream link: https://issues.redhat.com/browse/CRW-3261 |
@azatsarynnyy can we close this? Asking to decide if we can include it in the 7.55 release notes |
@RomanNikitenko @azatsarynnyy I have changed the title to reflect the actual new feature as it will be mentioned in the release notes. Can you please confirm it's correct? |
@l0rd VS Code for Eclipse Che is not bundled with OpenSSL 3 after fixing this issue. But OpenSSL 3 is already provided in UBI 9 image. I'd restate the title as |
The issue has been fixed by the PR: Also, we're going to extend the Che-Code readme docs with instructions for running VS Code in a UBI 9-based container. |
The instructions on how to run VS Code in a UBI9-based container: |
Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3633 |
@SDawley Are there any plans for 2024 to move Dev Spaces from UBI8 to UBI9 base images? |
Is your task related to a problem? Please describe
When running Che-Code in a UBI9-based container, it fails with the following error:
Describe the solution you'd like
Probably, it requires adding some libs to Che-Code image.
Describe alternatives you've considered
There was an internal discussion on the possibility of running Che-Code in any image. It requires reviewing how we package the VS Code. Also, there were some ideas to check about using the statically linked libraries.
Release Notes Text
Previously VS Code for Eclipse Che was failing to run on containers that had a version of OpenSSL that was not supported like for example UBI 9 that included OpenSSL 3.0.1). Now it will work independently from the version of OpenSSL included in the container.
The text was updated successfully, but these errors were encountered: