Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UDI dockerfiles to update-base-images GHA for weekly updates #21575

Closed
nickboldt opened this issue Jul 21, 2022 · 1 comment
Closed

add UDI dockerfiles to update-base-images GHA for weekly updates #21575

nickboldt opened this issue Jul 21, 2022 · 1 comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jul 21, 2022 •
edited
Loading

Is your task related to a problem? Please describe

In https://github.com/eclipse-che/che-release/blob/main/.github/workflows/update-base-images.yml#L9-L38 we list a number of Che projects which get weekly checks & PR generation when base images need updating.

The https://github.com/devfile/developer-images project should also be wired up to ensure base images are kept current w/ the latest CVE fixes.

Describe the solution you'd like

  1. Add https://github.com/devfile/developer-images into https://github.com/eclipse-che/che-release/blob/main/.github/workflows/update-base-images.yml#L9-L38
  2. Add comment lines into the dockerfiles that need to be kept current in https://github.com/devfile/developer-images

Comment lines must be in the form # https://repo-or-registry/organization/image

If a specific regex is required (eg., "must start with 7."), you can append that like this:

# https://quay.io/eclipse/che-machine-exec#^7\.

More examples here:

  1. Upload secret CHE_INCUBATOR_BOT_GITHUB_TOKEN using https://github.com/nickboldt/github-secrets-generator tool (and the secret file itself)

  2. get Mario to add the Che Incubator bot as a committer to the repo, so it can provide PRs

  3. verify it works by running https://github.com/eclipse-che/che-release/actions/workflows/update-base-images.yml against the new repo

  4. review notification in https://mattermost.eclipse.org/eclipse/channels/eclipse-che-ci

  5. merge PRs by running https://github.com/eclipse-che/che-release/blob/main/utils/approvePRs.sh (may require being a committer first)
@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 21, 2022
@nickboldt nickboldt changed the title add UDI dockerfiles to add UDI dockerfiles to update-base-images GHA for weekly updates Jul 21, 2022
@nickboldt nickboldt added the area/ci CI build and releases, PR testing, & whitelabel/productization issues label Jul 21, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 21, 2022
@nickboldt nickboldt added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 21, 2022
@nickboldt nickboldt mentioned this issue Nov 1, 2022
Closed
73 tasks
@nickboldt nickboldt mentioned this issue Nov 22, 2022
Closed
68 tasks
This was referenced Dec 5, 2022
Merged
Merged
This was referenced Dec 6, 2022
Open
Closed
Merged
@nickboldt
Copy link
Contributor Author

https://github.com/eclipse-che/che-release/actions/runs/3696079920/jobs/6259295991 ... succes!

merged: devfile/developer-images#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickboldt @che-bot