When starting a workspace with the same name as an existing one ask users if they wants to replace the pre-existing one

[ibuziuk]

Describe the bug

Getting Started workspace fails to start if there is an existing workspace

Che version

7.50@latest

Steps to reproduce

Expected behavior

exising cpp workspace is started

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

Note Dashboard should reopen any workspace if exists not only Getting Started

Release Notes Text

Previously, when starting a workspace with the same name of an existing one, Che would return an error and users should either manually delete the existing one or rename the new workspace. Now users are asked if they want to re-open the existing one or if they want to replace it with the new workspace.

[ibuziuk]

the issue is really annoying and we should backport the fix in 3.2

[l0rd]

Ok but we should not restart the workspace because it has the same name: it may have the same name but refer to another branch (i.e. you have just reviewed a PR) or even be a completely different git repository. How are we going to figure out if that's the same workspace or a different one?

[svor]

Can we just create a new workspace but with another name (maybe adding some suffix)

[l0rd]

Can we just create a new workspace but with another name (maybe adding some suffix)

Right but that's what generateName, in the DevWorkspace spec, is supposed to do. If the problem here is with samples I think we can use generateName instead of name when generating the DevWorkspace.

I think samples are easy because we start from a DevWorkspace.yaml. @ibuziuk the problem here is with a sample (i.e. if fails the second time you try a sample) right?

I can create a distinct issues for non-samples but in general I would ask the user if he wants to restart the existing workspace or replace it with the new one. To create multiple workspace using the same devfile it's recommended to leave the metadata.name empty in the devfile.yaml or use the new query parameter. But again, I think that's a distinct issue.

[l0rd]

I can create a distinct issues for non-samples but in general I would ask the user if he wants to restart the existing workspace or replace it with the new one. To create multiple workspace using the same devfile it's recommended to leave the metadata.name empty in the devfile.yaml or use the new query parameter. But again, I think that's a distinct issue.

@akurinnoy I have changed the title here because it looks that the issue is related to samples only. If that's not the case let's discuss it because the solution is not clear.

[max-cx]

Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3640

[devstudio-release]

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3850