Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: serverExposureStrategy missing performance impacts #21294

Closed
Hadsch opened this issue Mar 23, 2022 · 8 comments
Closed

Documentation: serverExposureStrategy missing performance impacts #21294

Hadsch opened this issue Mar 23, 2022 · 8 comments
Labels
area/doc Issues related to documentation

Comments

@Hadsch
Copy link

Hadsch commented Mar 23, 2022

At least on kubernetes, the setting serverExposureStrategy has a huge impact on the startup time of a workspace.

Here you can see a comparison (credits to @sparkoo):
https://www.youtube.com/watch?v=Fhzt8DiBajU
Link to the comment: #19461 (comment)

Option Startup-Time
single-host, type 'gateway' 17 sec
multi-host, type 'ingress' 55 sec
single-host, type 'ingress' 66 sec

Depending on which option you choose, the start time of a workspace can be increased or decreased by about 40 seconds.
In my opinion, this is a huge design decision that is not covered in the docs.

This is the page for the serverExposureStrategy:
https://www.eclipse.org/che/docs/che-7/installation-guide/configuring-workspace-exposure-strategies/

Expected documentation

Performance impact for each option

Note: This might be different on MiniKube or on OpenShift. But at least for Kubernetes this setting should be considered during the setup.

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 23, 2022
@benoitf benoitf added area/doc Issues related to documentation and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 23, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Mar 23, 2022

@Hadsch thanks for sharing the performance impact. Indeed single-host / gateway (the default one) is by far the fastest option from the workspace startup perspective. Would you be interested in contributing the performance impact warning to che-docs - https://github.com/eclipse-che/che-docs ?

@l0rd
Copy link
Contributor

l0rd commented Mar 23, 2022

@Hadsch what version of Che are you using? single-host using gateway should be the only option since 7.42 (when the switch to DevWorkspace happened). @sparkoo can you confirm?

@Hadsch
Copy link
Author

Hadsch commented Mar 24, 2022

Currently we are on 7.39.1 but we plan to update soon.

@l0rd + @ibuziuk: If its true, that this is the only option I think we can close this ticket. Otherwise, of course I can give it a try ;)

@sparkoo
Copy link
Member

sparkoo commented Mar 24, 2022

@Hadsch what version of Che are you using? single-host using gateway should be the only option since 7.42 (when the switch to DevWorkspace happened). @sparkoo can you confirm?

yes, devworkspaces runs only on gateway single-host. We should update the docs (I believe big docs refactorings for devworkspaces are in progress).

@Hadsch
Copy link
Author

Hadsch commented Mar 24, 2022

@l0rd: If it is the only option since 7.42 than it would still be the question why all three options are described?

@sparkoo
Copy link
Member

sparkoo commented Mar 24, 2022

@l0rd: If it is the only option since 7.42 than it would still be the question why all three options are described?

switch to devworkspaces is big update and docs haven't catch up yet

@Hadsch
Copy link
Author

Hadsch commented Mar 24, 2022

Perfect, then I will close the ticket now!

@Hadsch Hadsch closed this as completed Mar 24, 2022
@l0rd
Copy link
Contributor

l0rd commented Mar 24, 2022

Yes, big documentation refactoring / clean up is in progress #21264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation
Projects
None yet
Development

No branches or pull requests

6 participants