Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting workspaces from a Dockerfile #21187

Closed
l0rd opened this issue Feb 20, 2022 · 3 comments
Closed

Starting workspaces from a Dockerfile #21187

l0rd opened this issue Feb 20, 2022 · 3 comments
Labels
area/dashboard area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 20, 2022

Is your enhancement related to a problem? Please describe

If a developer wants to use a custom image from a Dockerfile he has to 1) pre-build it 2) push it to a registry 3) update the devfile to reference the just published image. This is bad UX.

Describe the solution you'd like

  • Support image components to use Dockerfile as component spec devfile/devworkspace-operator#1036
  • If needed, Eclipse Che Dashboard should replace the image.imageName and the container.image with a valid image reference (registry/org/name:tag) and the default registry, org and tag should be configurable at the CheCluster level.
  • A new Che URL parameter dockerfilePath should be supported. If this parameter is provided, Che should generate a DevWorkspace using the defaultComponents+ a new image component referencing the Dockerfile. If this parameter is provided Che should ignore any devfile at the root of the git repo.

Describe alternatives you've considered

Similar to image-puller, we could implement a service that would be responsible for the build of the images

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 20, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 20, 2022
@l0rd l0rd added area/devworkspace-operator team/controller severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. team/controller labels Feb 20, 2022
@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2022
@l0rd
Copy link
Contributor Author

l0rd commented Aug 19, 2022

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2022
@l0rd l0rd changed the title Support inner loop image components Support devfile image components with autobuild:true Jan 10, 2023
@l0rd l0rd changed the title Support devfile image components with autobuild:true Support devfile image components with autobuild:true Jan 10, 2023
@l0rd l0rd changed the title Support devfile image components with autobuild:true Starting workspaces from a Dockerfile Jan 25, 2023
@l0rd l0rd mentioned this issue Jan 25, 2023
32 tasks
@l0rd l0rd added the roadmap/3-months Epics that are planned to complete in the short term (within 3 months) label Jul 11, 2023
@che-bot
Copy link
Contributor

che-bot commented Jan 7, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2024
@che-bot che-bot closed this as completed Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

2 participants