Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all terminal options using Che-Code #21080

Closed
benoitf opened this issue Jan 27, 2022 · 2 comments
Closed

Handle all terminal options using Che-Code #21080

benoitf opened this issue Jan 27, 2022 · 2 comments
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Jan 27, 2022

Is your enhancement related to a problem? Please describe

There is a basic implementation of terminal across different containers of a pod using machine-exec

but it's lacking some features, like displaying the current terminals when reloading the window (it should display again the launched terminals)

There is also resize option and few other that are not implemented

Describe the solution you'd like

  • implement reload of previous terminal
  • implement resize

Additional context

vscode-terminal-problem.mov
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/editor/vscode Issues related to the Code OSS editor of Che labels Jan 27, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 27, 2022
@dmytro-ndp dmytro-ndp added area/machine-exec severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 27, 2022
@l0rd l0rd changed the title handle all terminal options using checode Handle all terminal options using checode May 30, 2022
@l0rd l0rd changed the title Handle all terminal options using checode Handle all terminal options using Che-Code May 30, 2022
@azatsarynnyy azatsarynnyy added this to the 7.50 milestone Jun 3, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Jun 3, 2022
64 tasks
@azatsarynnyy azatsarynnyy self-assigned this Jun 3, 2022
@azatsarynnyy
Copy link
Member

I've extracted the cursor problem to a separate issue #21473

@azatsarynnyy azatsarynnyy removed this from the 7.50 milestone Jun 29, 2022
@azatsarynnyy azatsarynnyy removed their assignment Jun 29, 2022
@azatsarynnyy
Copy link
Member

The previous multi-container terminal implementation has been replaced with the extension API-based
che-incubator/che-code#122
So, this issue isn't relevant anymore.
For any terminal-related issue, please create a separate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants