Update devfiles to use PROJECT_SOURCE instead of PROJECTS_ROOT

[benoitf]

Is your enhancement related to a problem? Please describe

most of our devfiles are single-project based.

so we should try to avoid to use PROJECTS_ROOT variable that is pointing to the parent folder of the project but use instead PROJECT_SOURCE variable that is pointing to the first project of the devfile.

Issue when using PROJECTS_ROOT is that if someone fork a repository and rename the repository name, devfile has still pointer to the previous project's name.

Describe the solution you'd like

• remove PROJECTS_ROOT in devfiles
• use PROJECT_SOURCE only if really needed as default working directory of commands should be PROJECT_SOURCE

so devfiles could be simplified

Describe alternatives you've considered

No response

Additional context

I've added editor area to be sure that when we execute commands, default directory if not specified is using PROJECT_SOURCE environment variable and not something else.

[vzhukovs]

Hi! If user omitted the workingDir parameter in Devfile, would it be added automatically in to the Flattened Devfile?

[vzhukovs]

And if Devfile didn't contain workingDir in the command, would the environment variable PROJECT_SOURCE point to the first project?

[benoitf]

yes that's correct

[vitaliy-guliy]

List of samples to be updated

• apache-camel-k https://github.com/che-samples/apache-camel-k/tree/devfilev2 / PROJECTS_ROOT is not used
• apache-camel-springboot https://github.com/benoitf/fuse-rest-http-booster/tree/devfilev2 -> Pull Request
• bash https://github.com/che-samples/bash/tree/devfilev2 -> Pull Request
• che4z
• cpp https://github.com/che-samples/cpp-hello-world/tree/devfilev2 -> Pull Request
• dotnet-asp.net https://github.com/che-samples/aspnetcore-realworld-example-app/tree/devfilev2 -> Pull Request
• dotnet
• go https://github.com/che-samples/golang-example/tree/devfilev2 -> Pull Request
• java-gradle
• java-lombok https://github.com/che-samples/lombok-project-sample/tree/devfilev2 -> Pull Request
• java-maven
• java-mongo https://github.com/che-samples/java-guestbook/tree/devfilev2 -> Pull Request
• java-mysql
• java-web-spring https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 -> Pull Request
• java-web-vertx
• nodejs-angular https://github.com/che-samples/nodejs-angular/tree/devfilev2 -> Pull Request
• nodejs-mongo https://github.com/che-samples/nodejs-mongodb-sample/tree/devfilev2 -> Pull Request
• nodejs-react https://github.com/che-samples/nodejs-react-redux/tree/devfilev2 -> Pull Request
• nodejs-yarn https://github.com/che-samples/react-web-app/tree/devfilev2 -> Pull Request
• nodejs https://github.com/che-samples/web-nodejs-sample/tree/devfilev2 -> Pull Request
• php-laravel
• php-mysql
• php-symfony https://github.com/che-samples/php-symfony/tree/devfilev2 -> Pull Request
• php-web-simple
• python-django https://github.com/che-samples/django-realworld-example-app/tree/devfile2 -> Pull Request
• python https://github.com/che-samples/python-hello-world/tree/devfilev2 -> Pull Request
• quarkus-command-mode
• quarkus https://github.com/che-samples/quarkus-quickstarts/tree/devfilev2 -> Pull Request
• rust https://github.com/che-samples/helloworld-rust/tree/devfilev2 -> Pull Request
• scala-sbt https://github.com/che-samples/scala-sbt/tree/devfilev2 -> Pull Request