Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding Che Theia plugins preferences and sidecar through .che/che-theia-plugins.yaml #20596

Closed
l0rd opened this issue Oct 6, 2021 · 6 comments · Fixed by eclipse-che/che-dashboard#405
Assignees
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 6, 2021

Is your enhancement related to a problem? Please describe

There is an issue to apply vs code extension preferences specified in the plugin registry (for che-theia plugins).

This issue is about overriding vs code extensions preferences using the file .che/che-theia-plugin.yaml in the git repository.

Describe the solution you'd like

If the file .che/che-theia-plugin.yaml in the git repository exists we should use it to override the spec of the plugins.

For example if the file .che/che-theia-plugin.yaml exist at the root of the repository:

- id: redhat/java8/latest
  override:
    preferences:
      java.server.launchMode: LightWeight
    sidecar:
      memoryLimit: 1280Mi 

the che-theia plugin should be included in the workspace and its default preferences and sidecar specification should be merged with the one in the file.

Describe alternatives you've considered

No response

Additional context

No response

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 6, 2021
@l0rd l0rd changed the title Support overriding Che Theia extensions preferences and sidecar through .che/che-theia-plugins.yaml Support overriding Che Theia plugins preferences and sidecar through .che/che-theia-plugins.yaml Oct 6, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 6, 2021
@l0rd l0rd added area/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 6, 2021
@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 6, 2021
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Oct 7, 2021
@svor svor mentioned this issue Oct 19, 2021
28 tasks
@sleshchenko
Copy link
Member

Does it include supporting overriding stuff from the editor? Like memoryLimit for theia from .che/editor.yaml...

@benoitf
Copy link
Contributor

benoitf commented Oct 21, 2021

This issue is only target Che theia plug-ins so not the editor

@benoitf
Copy link
Contributor

benoitf commented Oct 21, 2021

today you can add a custom .che/che-editor.yaml file that is defining (not overriding) your own editor (and then your own memory)

@sleshchenko
Copy link
Member

but https://che.eclipseprojects.io/2021/10/12/@mario.loriedo-devfile-v2-and-the-devworkspace-operator-p1.html says it's possible to override just memory for editor, and we even don't have an issue for that

@svor svor mentioned this issue Nov 9, 2021
18 tasks
@svor svor assigned svor and unassigned vinokurig Nov 10, 2021
@svor svor removed the sprint/next label Nov 10, 2021
@max-cx
Copy link

max-cx commented Nov 15, 2021

Hi, a question to the assignee of this issue:

Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide?

Yes/No?

@svor
Copy link
Contributor

svor commented Nov 16, 2021

There should be new documentation for End-user guide, I think it should be done by developer who will implement this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants