Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CDN support for Che-Theia PR build check #20391

Closed
azatsarynnyy opened this issue Sep 1, 2021 · 0 comments · Fixed by eclipse-che/che-theia#1208
Closed

Enable CDN support for Che-Theia PR build check #20391

azatsarynnyy opened this issue Sep 1, 2021 · 0 comments · Fixed by eclipse-che/che-theia#1208
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.36

Comments

@azatsarynnyy
Copy link
Member

Is your enhancement related to a problem? Please describe

In Che-Theia, we have some Webpack related customizations that are disabled by default. It's enabled only when CDN is used. See https://github.com/eclipse-che/che-theia/blob/main/generator/src/cdn/webpack-customizer.ts

For Che-Theia PR build check, we run the build w/o CDN support. It means that if some changes in a PR are related to Webpack build - they won't be tested properly.
See the latest example here #20390

Describe the solution you'd like

By enabling the CDN support for PR build checks, we ensure that the Webpack related changes are tested properly.

Describe alternatives you've considered

No response

Additional context

No response
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. sprint/current severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/theia Issues related to the che-theia IDE of Che labels Sep 1, 2021
@azatsarynnyy azatsarynnyy self-assigned this Sep 1, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Sep 1, 2021
Closed
1 task
@azatsarynnyy azatsarynnyy added this to the 7.36 milestone Sep 1, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Sep 1, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.36
Development

Successfully merging a pull request may close this issue.

Enable CDN support for PR build check eclipse-che/che-theia
1 participant
@azatsarynnyy