Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[single-host] none existing URLs to workspace should respond with 404 #20148

Closed
2 of 23 tasks
Tracked by #20444
sleshchenko opened this issue Jul 19, 2021 · 0 comments
Closed
2 of 23 tasks
Tracked by #20444
Assignees
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sleshchenko
Copy link
Member

Describe the bug

[single-host] none existing URLs to workspace should respond with 404.

It's inspired by the issue #19931 (CRW link can be found there as well), so technically, Dashboard remembered the previous run URL and tried to load it, so instead of getting 404, frame was redirected to Che API which redirected to dashboard so we ended with double dashboard.
If some plugin did mistake and used wrong URL, they will get Dashboard as well, instead of 404.

So, I expect gateway in addition to rules for server, add one common for all the workspaces, like /server*, which will just return 404.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Deploy Che in Single host.
  2. Try to open URL for non-existing workspace server, like CHE_HOST/serverany-non-existing.

Expected behavior

404 is returned.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. area/che-server labels Jul 19, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 19, 2021
@ScrewTSW ScrewTSW added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 19, 2021
@sparkoo sparkoo self-assigned this Sep 16, 2021
@sparkoo sparkoo closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants