[regression]Failed to run the "vscode-xml" plugin because of absence of the "redhat.vscode-commons" dependency

[Ohrimenko1988]

Describe the bug

Failed to run the "vscode-xml" plugin because of absence of the "redhat.vscode-commons" dependency

Che version

• [ x ] latest
• nightly
• other: please specify

Steps to reproduce

• Create workspace using next devfile:

apiVersion: 1.0.0
metadata:
  name: xml-plugin-test
projects:
  - name: nodejs-web-app
    source:
      location: 'https://github.com/che-samples/web-nodejs-sample.git'
      branch: che-qe-tests
      type: git
components:
  - id: redhat/vscode-xml/latest
    type: chePlugin

• Go inside created workspace
• Open the "hello.xml" file
• Pay attention to the displayed notifications with errors (see attachments)

Expected behavior

The "vscode-xml" plugin activated and ready to work

Observed behavior

Activation of the "vscode-xml" plugin has been failed.

Runtime

• kubernetes (include output of kubectl version)
• Openshift (include output of oc version)
• [ x ] minikube (include output of minikube version and kubectl version)
• minishift (include output of minishift version and oc version)
• docker-desktop + K8S (include output of docker version and kubectl version)
• other: (please specify)

Screenshots

Installation method

• [ x ] chectl

chectl server:deploy \
  --k8spodreadytimeout=600000 \
  --k8spodwaittimeout=600000 \
  --k8spoddownloadimagetimeout=600000 \
  --listr-renderer=verbose \
  --platform=minikube \
  --chenamespace=iokhrime-che \
  --telemetry=off

• OperatorHub
• I don't know

Environment

• [ x ] my computer
  • Windows
  • [ x ] Linux
  • macOS
• Cloud
  • Amazon
  • Azure
  • GCE
  • other (please specify)
• Dev Sandbox (workspaces.openshift.com)
• other: please specify

Eclipse Che Logs

Additional context

[Ohrimenko1988]

Looks like related to the #19361

[svor]

Probably need to update vscode-xml to 0.17.0 where the dependency to vscode-commons was removed redhat-developer/vscode-xml#503

[apupier]

using 0.17.0 might cause troubles because it requires vscode-languageclient 7.0.0 (compared to 0.16.1 which requires 5.2.1). It means that it requires VS Code API 1.52.0 which is not yet supported. Even if it is not what is mentioned in the vscode-xml package.json

[apupier]

Where si played this test https://github.com/eclipse/che/blob/main/tests/e2e/tests/plugins/VscodeXmlPlugin.spec.ts ? Any ideas why it has not failed the build?

[svor]

Where si played this test https://github.com/eclipse/che/blob/main/tests/e2e/tests/plugins/VscodeXmlPlugin.spec.ts ? Any ideas why it has not failed the build?

@Ohrimenko1988 ^^