Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter memory leak related problems #19200

Closed
2 of 3 tasks
RomanNikitenko opened this issue Mar 3, 2021 · 3 comments
Closed
2 of 3 tasks

Emitter memory leak related problems #19200

RomanNikitenko opened this issue Mar 3, 2021 · 3 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Mar 3, 2021

Describe the bug

The bug was reported in the Eclipse Che mattermost channel.

Che user detected a lot of logs in the browser console, also it's impossible to run a task

The logs:
WARN Possible Emitter memory leak detected. 196 listeners added. Use event.maxListeners to increase the limit (175). MOST frequent listener (120):
logger-protocol.ts:112 root WARN     at e.onDidRunOperation (https://routenss68q01-rnikiten-che.apps.che-dev.x6e0.p1.openshiftapps.com/theia.0211f3f21f574190b0b7.js:1:3450082
 
WARN Possible Emitter memory leak detected. 203 listeners added. Use event.maxListeners to increase the limit (175). MOST frequent listener (127):
root WARN     at e.onDidChangeFileSystemProviderCapabilities (https://routenss68q01-rnikiten-che.apps.che-dev.x6e0.p1.openshiftapps.com/theia.0211f3f21f574190b0b7.js:1:3450082
ERROR Child node 'file-change-tree-root' does not belong to this 'file-change-tree-root' tree.

I checked it using a workspace from Angular stack and faced with the state when:

  • nodes in the Explorer view are loading few seconds
  • My workspace panel is empty
  • opening a file takes few seconds

then the IDE goes to offline mode. Refreshing a page fixes the issue

Additional info from the user:

I made some changes in che-theia removing

  "vscode-git": "https://open-vsx.org/api/vscode/git/1.49.3/file/vscode.git-1.49.3.vsix",
  "vscode-github": "https://open-vsx.org/api/vscode/github/1.50.1/file/vscode.github-1.50.1.vsix"

and

plugins/github-auth-plugin

now both issues disappeared, the file-change-tree-root and also Possible Emitter memory leak detected and the tasks are working well.

Che version

  • latest
  • nightly
  • other: 7.26.1

Steps to reproduce

  1. Start a workspace using Angular devfile from dashboard.
  2. Try to do simple actions - like opening a file, expand packages in the Explorer view.

Runtime

dogfooding instance

Screenshots

memory_leak_angular

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 3, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 3, 2021
@azatsarynnyy
Copy link
Member

need to check it once the eclipse-theia/theia#9045 is merged

@ericwill ericwill added area/editor/theia Issues related to the che-theia IDE of Che area/git severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 4, 2021
@ericwill
Copy link
Contributor

ericwill commented Mar 4, 2021

cc @vinokurig please check it after eclipse-theia/theia#9045 is merged

@vinokurig
Copy link
Contributor

I am closing it because it is not reproducible after eclipse-theia/theia#9045 is merged. Although there are some root ERROR Child node 'file-change-tree-root' does not belong to this 'file-change-tree-root' tree. console errors, there is another issue opened for that: eclipse-theia/theia#7953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants