Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus welcome page gets shown again and again #17994

Closed
l0rd opened this issue Sep 30, 2020 · 4 comments
Closed

Quarkus welcome page gets shown again and again #17994

l0rd opened this issue Sep 30, 2020 · 4 comments
Assignees
@vitaliy-guliy
Labels
area/editors area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 30, 2020

Describe the bug

When Quarkus VS Code extension is started a welcome page is automatically opened.

image

At the very bottom of that page a checkbox allow to opt out.

image

But even if I uncheck "Show welcome page when using Quarkus Tools" the welcome page will be shown next time I restart the Che workspace.

Che version

che.osio

Steps to reproduce

  • Start the Quarkus Tools stack on che.osio.
  • Open a Java file and wait for the "Quarkus Tools for Eclipse Che" welcome page to open.
  • Uncheck "Show welcome page when using Quarkus Tools"
  • Restart the Che workpace and observe that the "Quarkus Tools for Eclipse Che" welcome page to opens again.

Expected behavior

  1. The welcome page should not be opened when restarting the workspace.
  2. The welcome page should not be opened even when creating a new workspace that have the Quarkus Tools.
  3. There should be some space between the checkbox "Show welcome page when using Quarkus Tools" and the line above in the Quarkus welcome page.
@l0rd l0rd added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 30, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 30, 2020
@l0rd l0rd mentioned this issue Sep 30, 2020
Closed
16 tasks
@mmorhun mmorhun added severity/P2 Has a minor but important impact to the usage or development of the system. area/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 30, 2020
@ericwill
Copy link
Contributor

Might be related to #16352 ?

@ericwill ericwill mentioned this issue Oct 7, 2020
Closed
27 tasks
@ericwill ericwill added this to the 7.21 milestone Oct 7, 2020
@vitaliy-guliy
Copy link
Contributor

Clicking on the checkbox is not handled, because there is no necessary javascript injected in webview frame. The problem is because quarkus extension is running in sidecar, and for that extensions we have an issue with loading resources into webviews #16870

Screenshot from 2020-10-20 16-17-38

@vzhukovs
Copy link
Contributor

Checked this use case in che-theia master. Issue seems is not reproducible anymore.

@ericwill
Copy link
Contributor

ericwill commented Jan 4, 2021

Checked this use case in che-theia master. Issue seems is not reproducible anymore.

Thanks for checking, closing the ticket now.

@ericwill ericwill closed this as completed Jan 4, 2021
@ericwill ericwill removed this from the 7.x (Later, Future, Never) milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
area/editors area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@l0rd @vitaliy-guliy @vzhukovs @ericwill @mmorhun @che-bot