Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud shell must propagate error when it failed to initialize terminal #16249

Closed
sleshchenko opened this issue Mar 6, 2020 · 3 comments
Closed

Cloud shell must propagate error when it failed to initialize terminal #16249

sleshchenko opened this issue Mar 6, 2020 · 3 comments
Assignees
@AndrienkoAleksandr
Labels
area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.12

Comments

@sleshchenko
Copy link
Member

Is your enhancement related to a problem? Please describe.

Currently, when the cloud shell failed to initialize terminal - it shows nothing.
It's needed to display an error when happened.

Screenshot_20200303_174223
@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. team/deploy area/machine-exec labels Mar 6, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 6, 2020
@l0rd l0rd mentioned this issue Mar 6, 2020
Closed
38 tasks
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 6, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Mar 20, 2020
@tolusha tolusha mentioned this issue Mar 26, 2020
Closed
43 tasks
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Apr 6, 2020
@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Apr 7, 2020
Merged
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.12 Apr 7, 2020
@sleshchenko
Copy link
Member Author

I've just tested the nightly build and it does not seem to be fixed. Maybe I did something wrong

Screenshot_20200408_120516
Screenshot_20200408_120526

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Apr 8, 2020
Merged
@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Apr 8, 2020 •
edited
Loading

I've just tested the nightly build and it does not seem to be fixed. Maybe I did something wrong

@sleshchenko Yes, sorry, it is really doesn't work, I tested my previous pr with another errors flow. I created one more pr, it should work and I tested it with che-workspace-operator eclipse-che/che-machine-exec#91 . Thanks for good testing and feedback.

@sleshchenko
Copy link
Member Author

Now it works 🎉
but still some fix is needed to process \n in the right way
Screenshot_20200409_145534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.12
Development

No branches or pull requests
4 participants
@tolusha @sleshchenko @AndrienkoAleksandr @che-bot