Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che 7.9.2 Release #16229

Closed
19 of 27 tasks
nickboldt opened this issue Mar 4, 2020 · 25 comments
Closed
19 of 27 tasks

Che 7.9.2 Release #16229

nickboldt opened this issue Mar 4, 2020 · 25 comments
Assignees
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Mar 4, 2020

List of pending issues / PRs

Release status

In parallel, the following releases can be done:

  • che-theia,
  • che-machine-exec,
  • che-devfile registry, then che-plugin-registry (once che-theia and machine-exec are done)
  • che-parent, then che-docs, then che as Release Candidate for QE

Then in series:

  • che-parent, then che-docs, then che as Release
  • che-operator, then chectl
  • che-theia (1eaecd5cbf93468a74988ddcd347402fcbf14cbe)
  • che-machine-exec
  • che-plugin-registry (depends on che-theia, che-machine-exec)
  • che-devfile-registry
  • che-parent
  • che-docs (depends on parent)
  • che (depends on docs and parent)
  • che-operator (depends on all of the above)
    • Kubernetes community operator PR
    • OpenShift community operator PR
  • chectl (depends on all of the above)
  • complete current milestone
    • move incomplete deferred issues to backlog
    • move incomplete WIP issues to next milestone
    • close completed issues
    • close milestone
Owner Process Script CI Artifact(s)
@azatsarynnyy che-theia MANUAL centos quay.io/eclipse/che-theia
@nickboldt / @mkuznyetsov che-machine-exec make-release.sh centos quay.io/eclipse/che-machine-exec
@nickboldt / @mkuznyetsov che-devfile-registry make-release.sh centos quay.io/eclipse/che-devfile-registry
@nickboldt / @mkuznyetsov / @ericwill che-plugin-registry make-release.sh centos quay.io/eclipse/che-plugin-registry
@vparfonov / @mkuznyetsov che-parent MANUAL centos che-parent, che.depmgt
@vparfonov / @mkuznyetsov che-docs MANUAL centos che-docs
@vparfonov / @mkuznyetsov che MANUAL centos che.core, quay.io/eclipse/che-server
@tolusha che-operator make-release.sh ? quay.io/eclipse/che-operator
@tolusha chectl make-release.sh travis chectl releases
@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 4, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 4, 2020
@nickboldt nickboldt added this to the 7.11.0 milestone Mar 4, 2020
@nickboldt nickboldt mentioned this issue Mar 4, 2020
24 tasks
@azatsarynnyy
Copy link
Member

The patch for about dialog already included in 7.9.1

@nickboldt
Copy link
Contributor Author

Then please... fix my mistake. Link to the commit. Remove the incorrect entry on this issue and move it to 7.9.1 issue.

Like this:

image

If you see something, don't just say something. FIX IT. Make it clear. Cite sources. Prove your work.

You have the power. Please use it. :D

@tolusha tolusha removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 6, 2020
@nickboldt
Copy link
Contributor Author

slip to 7.11:

@dmytro-ndp
Copy link
Contributor

@nickboldt: can we include fix of import in Che with TLS in this release: eclipse-che/che-theia#672 ?

@azatsarynnyy azatsarynnyy mentioned this issue Mar 18, 2020
19 tasks
@mkuznyetsov
Copy link
Contributor

waiting for QE to proceed with RC testing

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 19, 2020

@davidfestal, @tolusha: installation of Multiuse User Eclipse Che 7.9.2.RC on minikube 1.1.1 using chectl:next and che-operator:nightly had failed:

[05:26:34] starting [started]
[05:29:37] starting [failed]
[05:29:37] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
[05:29:37] Eclipse Che pod bootstrap [failed]
[05:29:37] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
[05:29:37] ✅  Post installation checklist [failed]
[05:29:37] → ERR_TIMEOUT: Timeout set to pod ready timeout 180000
 ›   Error: Error: ERR_TIMEOUT: Timeout set to pod ready timeout 180000
 ›   Installation failed, check logs in '/tmp/chectl-logs/1584609994324'

Could you, please, say which version of chectl and che-operator we should use to check installation of Eclipse Che 7.9.2.RC?

@nickboldt
Copy link
Contributor Author

nickboldt commented Mar 19, 2020

Have you tried using the 7.9.1 version of operator/chectl?

Was there anything useful in the logs to explain WHY it timed out?

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 19, 2020

I can try with che-operator:7.9.1.
The problem is the next fixup are in https://github.com/eclipse/che-operator/commits/7.9.x branch, so we can't check it with che-operator:7.9.1:

@nickboldt
Copy link
Contributor Author

Sure but you also can't check it with the 7.10 or 7.11 operator either :D

@davidfestal
Copy link
Contributor

For now you can use quay.io/dfestal/che-operator:fix-devfile-registry-public-url
It is based on 7.9.x + my fixes that I added on the 7.9.x.

But I assume that if you need to continuously test the bits of the 7.9.x branch we should have a CI that produces docker images from here.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 19, 2020

That is why we need to have che-operator:7.9.2 image, and chectl:7.9.2 which will be used later to build crwctl for CRW 2.1.0.

@nickboldt
Copy link
Contributor Author

Are you suggesting that we should revise the release process so that @tolusha will release the operator and chectl BEFORE che server 7.9.2 is live?

Would that work?

@dmytro-ndp
Copy link
Contributor

Yes - it would be perfect!

@mkuznyetsov
Copy link
Contributor

mkuznyetsov commented Mar 19, 2020

while David provided newer che-operator, here is how you could build newest chectl:

git clone https://github.com/che-incubator/chectl
cd chectl && git checkout 7.9.x
yarn

use compiled binaries from "bin" directory

@davidfestal
Copy link
Contributor

we don't need the che-server maven artifacts to release che-operator and chectl
We do need the che-server docker images though (at least to test the released bits, which we do during the release)

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 19, 2020

It's okay to have hardcoded che-server:7.9.2, che-keycloak:7.9.2 in che-operator:7.9.2 for pre-release testing so that we are replacing existed tags with rc when installing Che by using custom-resource.yaml

@dmytro-ndp
Copy link
Contributor

@mkuznyetsov: we can't build chectl from https://github.com/che-incubator/chectl/commits/7.9.x on CRW CCI because there is too old node version:

Cloning into 'chectl'...
Switched to a new branch '7.9.x'
Branch 7.9.x set up to track remote branch 7.9.x from origin.
yarn install v1.21.1
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.11.1"
error Found incompatible module.

Also I don't see significant changes compare to chectl:7.9.1 in https://github.com/che-incubator/chectl/commits/7.9.x. So, IMHO, we can use chectl:7.9.1 this time.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 19, 2020

@davidfestal, @nickboldt: Eclipse Che 7.9.2.RC installation failed because the was tlsSupport: true set in https://github.com/eclipse/che-operator/blob/7.9.x/deploy/crds/org_v1_che_cr.yaml#L40.

We need to backport commit which disabled installation of Che in TLS mode in pre-release testing scripts into 7.9.x branch.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 20, 2020

@mkuznyetsov, @nickboldt, @davidfestal:
We have managed to run E2E tests against Eclipse Che 7.9.2.RC:

  • quay.io/eclipse/che-server:rc
  • quay.io/eclipse/che-keycloak:rc
  • quay.io/eclipse/che-theia:7.9.2
  • quay.io/eclipse/che-theia-endpoint-runtime-binary:7.9.2
  • quay.io/eclipse/che-devfile-registry:7.9.2
  • quay.io/eclipse/che-plugin-registry:7.9.2
  • quay.io/eclipse/che-plugin-artifacts-broker:v3.1.1
  • quay.io/eclipse/che-endpoint-watcher:7.9.2
  • chectl:7.9.1
  • quay.io/dfestal/che-operator:fix-devfile-registry-public-url (it should have required changes)
  • centos/postgresql-96-centos7:9.6

Current result against Multiuser Eclipse Che 7.9.2.RC without TLS support:

  1. Java selenium tests passed on minishift 3.11 https://ci.centos.org/view/Devtools/job/devtools-che-rc-multiuser-integration-tests/27/
  2. OS OAuth integration tests passed on minishift 3.11 https://ci.centos.org/view/Devtools/job/devtools-che-rc-ocp-oauth-test/28/
  3. Rolling update tests passed on minishift 3.11 https://ci.centos.org/view/Devtools/job/devtools-che-rc-rolling-strategy-test/28/

Also, @davidfestal reported that he had successfully tested fixes related to che-operator:7.9.x on a disconnected OS 4.3 cluster, installed with the restricted environment procedure, with proxies + TLS + selfsigned certificates enabled. Result was a successfully started Java Gradle workspace, with working basic services like terminal, JDTLS, outlines, and commands.

Next tests are in-progress:

  1. Happy path tests, Vert.x, Java Maven and Python devfile tests on minikube 1.1.1
  2. GitHub integration tests.
  3. Testing of Eclipse Che with TLS support.

@dmytro-ndp
Copy link
Contributor

Happy path tests, Vert.x, Java Maven and Python devfile tests against Multiuser Eclipse Che 7.9.2.RC on minikube 1.1.1 have passed successfully: https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/che-regular-tests/view/pre-release/job/MultiUser-Che-release-check-e2e-tests-against-k8s/50/

@dmytro-ndp
Copy link
Contributor

GitHub integration tests have passed as well.

@dmytro-ndp
Copy link
Contributor

It was decided to create Eclipse Che 9.7.2.RC2 with the next fix inside:

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 20, 2020

Current result against Multiuser Eclipse Che 7.9.2.RC2 without TLS support:

Version number is been displayed correctly in Dashboard:
Screenshot from 2020-03-20 20-01-32

If there is nothing else needed to test, Eclipse Che 7.9.2.RC2 can be release.

@nickboldt
Copy link
Contributor Author

Che 7.9.2 server and docs are live in quay and maven central. ~ 11pm EST Mar 20.

@tolusha
Copy link
Contributor

tolusha commented Mar 23, 2020

che-operator and chectl released.

@sunix sunix added the kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

10 participants