Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do NOT push che-theia nightly image if it breaks Che happy path test #15690

Closed
nickboldt opened this issue Jan 14, 2020 · 3 comments
Closed

Do NOT push che-theia nightly image if it breaks Che happy path test #15690

nickboldt opened this issue Jan 14, 2020 · 3 comments
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
Backlog - QE

Comments

@nickboldt
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Per CRW 2 retrospective discussions, we don't want to blindly pull latest theia as it can (has) broken happy path tests; need versioned tests (CRW 2.x lags behind Che 7.x so need two versions of happy path).

Describe the solution you'd like

Need to write new check on nightly theia; if image check does not pass, do NOT push new image to quay.
@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 14, 2020
@nickboldt
Copy link
Contributor Author

May be related to / duplicate of #13258

@l0rd l0rd changed the title write new check on nightly theia; if image check does not pass, do NOT push new image to quay. Do NOT push che-theia nightly image if it breaks happy path test Jan 15, 2020
@l0rd l0rd added team/che-qe area/ci CI build and releases, PR testing, & whitelabel/productization issues labels Jan 15, 2020
@l0rd l0rd changed the title Do NOT push che-theia nightly image if it breaks happy path test Do NOT push che-theia nightly image if it breaks Che happy path test Jan 15, 2020
@l0rd
Copy link
Contributor

l0rd commented Jan 15, 2020

The fix should be to NOT publish che-theia (not theia) image to prevent that Che PR check get broken. The head of che-theia master branch should continue to reference the head of theia master branch (we want to fix problems on theia master branch as soon as possible).

It's not a duplicate of #13258. cc @rhopp @dmytro-ndp is there a duplicate of this issue?

Assigning to QE team but may be addressed by productization team as well (@nickboldt if you think you can address it please change the assignment).

@l0rd l0rd added the severity/P1 Has a major impact to usage or development of the system. label Jan 15, 2020
@rhopp rhopp added this to the Backlog - QE milestone Jan 22, 2020
@rhopp
Copy link
Contributor

rhopp commented Jan 22, 2020

Closing as duplicate of #15291

@rhopp rhopp closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
Backlog - QE
Development

No branches or pull requests
3 participants
@nickboldt @l0rd @rhopp