Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation for tasks is required #14098

Closed
4 of 23 tasks
RomanNikitenko opened this issue Aug 1, 2019 · 4 comments
Closed
4 of 23 tasks

Adaptation for tasks is required #14098

RomanNikitenko opened this issue Aug 1, 2019 · 4 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Aug 1, 2019

The bug is relevant for eclipse/che-theia:next, so for master branch assembly.

Describe the bug

After alignment theia tasks with vs code behavior we need some adaptation on our side.

I still can run che tasks, but at least:

  • configure task action is not working
  • detected tasks are displayed in different way
  • after page refreshing Terminal -> Run Task menu action is triggered only on second click
    Please see the video: https://youtu.be/DXe_R-ubxa8

I tested it on theia side and it works well.
Looks like some changes for task definitions are required on our side.

Che version

  • latest
  • nightly
  • other: eclipse/che-theia:next

Steps to reproduce

  1. Add to a devfile the section:
- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor
  1. Start a workspace from the devfile
  2. Go to Terminal -> Run task
    You can see that for detected tasks the type of the task is used, not source (for example, shell instead of npm )
  3. Try to configure a detected task - click on cog icon - the configuration should be copied to tasks.json file, but nothing is happen.

Expected behavior

  • ability to configure a detected tasks
  • source field is used for displaying of detected tasks
  • after page refreshing Terminal -> Run Task menu action is triggered on first click

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube v1.0.0
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Actual displaying
actual

Expected displaying
expected

Installation method

  • chectl chectl/0.0.2-6d3894f linux-x64 node-v10.4.1
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 1, 2019
@vparfonov
Copy link
Contributor

cc @slemeur I think we need to take it for 7.1
WDYT?

@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk ibuziuk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@ibuziuk ibuziuk added this to the 7.1.0 milestone Aug 1, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Aug 1, 2019

@slemeur moved to 7.1.0 for now

@ibuziuk ibuziuk added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. labels Aug 1, 2019
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Aug 7, 2019

I added to the description of the issue one more use case related to Terminal -> Run Task menu.
The video for the case is available as well.

The bug was caused by last changes in master branch of theia repo. I can not reproduce it for theia project, so some changes are required on che-theia side.

@RomanNikitenko
Copy link
Member Author

I investigated the issue: the bugs related to detected tasks are caused by using 7.0.0-next version of eclipse/che-theia-endpoint-runtime for remote plugins. 7.0.0-next version doesn't contain activateByEvent logic.

So the issue is fixed by using next version of eclipse/che-theia-endpoint-runtime for remote plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants