Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain specific features added on top of Visual Studio Code #2505

Merged
merged 9 commits into from
Dec 7, 2022
Merged

docs: explain specific features added on top of Visual Studio Code #2505

merged 9 commits into from
Dec 7, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Nov 23, 2022

What does this pull request change?

Explain specific features added on top of Visual Studio Code, such as process monitoring plugin.

To find the content for this pull request, I read the README for all che- prefixed extensions in a running workspaces.

$ for e in /checode/checode-linux-libc/extensions/che-*/README.md ; do echo $e ; cat $e ; done

Screenshot from 2022-12-05 16-37-48

What issues does this pull request fix or reference?

fixes: https://issues.redhat.com/browse/RHDEVDOCS-4596

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

github-actions bot commented Nov 23, 2022

🎊 Navigate the preview: https://638f401dd6478227572f490d--eclipse-che-docs-pr.netlify.app 🎊

@themr0c themr0c added this to the 7.56 milestone Nov 23, 2022
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions, let me know what you think.

modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@themr0c themr0c requested a review from l0rd November 24, 2022 14:50
@l0rd
Copy link
Contributor

l0rd commented Nov 28, 2022

You may be already aware but @azatsarynnyy has opened this issue on the same subject. The issues has a complete list of things that the VS Code distributed with Che adds on top of Code - OSS.

@l0rd
Copy link
Contributor

l0rd commented Nov 28, 2022

This is okeish but ideally you want to specify what's provided on top of other IDEs too such as Theia / IntelliJ and PyCharm. A recurring question is if IntelliJ has a plugin-port, idling, devfile commands etc...

@azatsarynnyy
Copy link
Member

This is okeish but ideally you want to specify what's provided on top of other IDEs too such as Theia / IntelliJ and PyCharm. A recurring question is if IntelliJ has a plugin-port, idling, devfile commands etc...

@l0rd yes, we implemented all the mentioned features in our build of the IntelliJ IDEA editor.
The related issues are:

"idling" - if stopping the idled workspace is meant here, it should work. If preventing a workspace from being stopped is meant, it's not implemented.

@themr0c themr0c requested a review from l0rd December 5, 2022 15:40
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @azatsarynnyy please review.

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited the full official name of VS Code.

modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/developer-workspaces.adoc Outdated Show resolved Hide resolved
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@themr0c themr0c merged commit 4923397 into eclipse-che:main Dec 7, 2022
@themr0c themr0c deleted the rhdevdocs-4596-process-monitoring-plugin branch December 7, 2022 08:59
themr0c added a commit that referenced this pull request Dec 7, 2022
themr0c added a commit that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants