Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#374] fix missing labels #375

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

ghentschke
Copy link
Contributor

due to the change 502154 'Add "Move to Line" and related actions to debugger context menu' the labels for the Editor (LSP) in the properties and preference page couldn't be found anymore.

the default bundle-lcoalization folder is OSGI-INF/I10n

fixes #374

due to the change 502154 'Add "Move to Line" and related actions to
debugger context menu' the labels for the Editor (LSP) in the properties
and preference page couldn't be found anymore.

the default bundle-lcoalization folder is OSGI-INF/I10n

fixes eclipse-cdt#374
@ghentschke ghentschke merged commit 2639a46 into eclipse-cdt:master Sep 16, 2024
3 checks passed
@ghentschke ghentschke deleted the fix-missing-labels branch September 16, 2024 07:54
@ruspl-afed
Copy link
Member

Interesting, we managed to miss this during review

@ghentschke
Copy link
Contributor Author

jupp

@travkin79
Copy link
Contributor

Hi @ghentschke and @ruspl-afed,
I'm sorry for that. I didn't see that the change corrupted the labels. Good, you found it.

@ruspl-afed
Copy link
Member

No problem @travkin79
Every change we make has the potential to disrupt other systems, but that's not a reason to stop improving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing labels in properties and preference pages
3 participants