Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated PDF ignores "line-height" CSS property for "line-height" < 100% #1123

Closed
luzhanov opened this issue Dec 1, 2022 · 1 comment · Fixed by #1124
Closed

Generated PDF ignores "line-height" CSS property for "line-height" < 100% #1123

luzhanov opened this issue Dec 1, 2022 · 1 comment · Fixed by #1124
Milestone
4.13

Comments

@luzhanov
Copy link
Contributor

luzhanov commented Dec 1, 2022

We're using BIRT 4.9.0 for generating PDF reports.
The issue we've faced is that generated PDFs doesn't respect the CSS property line-height in cases when this property is < 100%.

Debugging shows that the reason is logic in LineArea and InlineStackingArea classes. I will provide a PR which fixes this.

Attached file is a sample .rptdesign template which shows the problem.
line-height-test-20221201-1915.zip

This issue was present in BIRT 4.4.2 also.
@luzhanov
Copy link
Contributor Author

luzhanov commented Dec 1, 2022

PR with issue fix: #1124

@wimjongman wimjongman linked a pull request Dec 2, 2022 that will close this issue
Fix for the PDF "line-height" < 100% bug #1123 #1124
Merged
@wimjongman wimjongman added this to the 4.13 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13
Development

Successfully merging a pull request may close this issue.

Fix for the PDF "line-height" < 100% bug #1123
2 participants
@wimjongman @luzhanov