Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errorCb to server interceptors and update readme #19

Closed
wants to merge 1 commit into from

Conversation

Robin-Hoodie
Copy link

No description provided.

@Robin-Hoodie Robin-Hoodie mentioned this pull request Jan 29, 2019
@zoltrain
Copy link
Contributor

Hello!

First of thanks for the PR, we're no longer using this internally hence why it's been quiet. I thought grpc-node would've added interceptors by now but it seems an API hasn't even been discussed yet. grpc/grpc-node#419 This PR looks good but @Robin-Hoodie would it be possible to add a test to make sure it's being called on error?

@Robin-Hoodie
Copy link
Author

Hey @zoltrain , I created this PR a long time ago and don't remember a lot of the code.

As you're no longer using this internally, can I ask what you're using instead?

@zoltrain
Copy link
Contributor

@Robin-Hoodie We've moved over to Go, and the official grpc module which has support for interceptors. It's not that this isn't useful in node world, it's just not something we use everyday anymore. It was the fact that node lacked support that we created this in the first place, we found good observability is hard with out this type of pattern.

@jonbretman jonbretman closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants