Syntax highlight the signature preview

[leo-unglaub]

Contributing guidelines

• I have read CONTRIBUTING.md
• I have read CODE_OF_CONDUCT.md

Module(s)

mini-completion

Description

Hey,
first of all, i love your plugins, they are clean, easy to setup and work really fast. I love that. Thanks so much for providing them.

I noticed a small thing that might be an improvement. Right now the signature preview is in one color, buy with larger signatures it would be helpful to have them rendered with syntax highlighting on. It would, at least for me, improve the readability.

What do you think? Is that worth the work or not?
Thanks so much and greetings
Leo

[leo-unglaub]

Here is a better screenshot for a method that has a huge signature:

[echasnovski]

Thanks for suggestion and kind words!

This is interesting and might be doable. There are at least the following issues with it:

• I don't think it is guaranteed that signature help is a valid code of a language at hand. Thus it might not be good for parsing.
• Needs separate logic for initializing that highlight.
• This will introduce slight overhead because adding highlighting is not exactly immediate (needs parsing, etc.).

I'll think about it.

[leo-unglaub]

Those are some very well thought out concerns, you are right. My idea was as follows:

• Only do it if Treesitter is attached to the current buffer
• If its not valid code for the given language in the buffer, treesitter will fail very quickly
• Treesitter selectors could be used for still highlighting the current item
• There is a default debounce on this signature helper anyway, so it should be enought time for Treesitter to parse and render (beeing laggy would be horrible)

Greettings
Leo