Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message on login is not visible on mobile broswers. #1288

Open
faseehahmad00 opened this issue Mar 21, 2023 · 2 comments
Open

Error message on login is not visible on mobile broswers. #1288

faseehahmad00 opened this issue Mar 21, 2023 · 2 comments
Assignees

Comments

@faseehahmad00
Copy link

If there is some issue with login the form does not display any message and feels irresponsive. Actually the error toast is displayed below login form and is visible as soon as login form is closed.
Below is the attached screenshot after I closed the form.

IMG-1782

Platform : Brave Browser for IOS.

@feruzm
Copy link
Member

feruzm commented Mar 21, 2023

@faseehahmad00 Thank you, you are right, we should show error messages within form so info is visible clearly. We will fix it.

@MTSaeed
Copy link
Collaborator

MTSaeed commented Mar 21, 2023

Hi @feruzm
I understand the issue. There are two approaches to overcome this issue.

  1. By increasing the z-index of toaster message. By doing this, the error message will display above the login form. This thing has been handled in Manage-authorities PR. when you will merge that PR, the issue is being resolved.
  2. By putting the error message within the form as you mentioned in your above comment.

Now kindly suggest your opinion. If you would like to go with 2nd approach, i will resolve this issue by showing the error message within login form but if you would like to go with 1st approach then this thing is already handled in manage-authorities PR and you just need to review and merge that PR.

Fix by using Approach 1:

login-error-message-fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants