Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paris] Implement stake, unstake & finalize_unstake pseudo operations in the Wallet API #2921

Closed
3 of 4 tasks
dsawali opened this issue Apr 16, 2024 · 0 comments · Fixed by #2935
Closed
3 of 4 tasks
Assignees
Labels
enhancement New feature or request Paris wallet
Milestone

Comments

@dsawali
Copy link
Contributor

dsawali commented Apr 16, 2024

This ticket is a follow up to the Contract API counterpart: #2886

Wallet API support

  • staker related:
    • stake
    • unstake
    • finalize_unstake
  • baker related:
    • set_delegate_parameters

Note:

  • The endpoint GET - /chains/main/blocks/head/context/adaptive_issuance_launch_cycle can be used as a heuristic to check whether Adaptive Issuance is enabled in the protocol - [Paris] new adaptive issuance rpc endpoints (generic) #2678
    it returns the cycle it started (i.e.6) need to compare it with the head block .metadata.level_info.cycle to confirm it started

Protocol Oxford will bring forth a feature flag, that when enabled, will allow users to perform stake, unstake, and finalize_unstake pseudo operations on implicit accounts.

Support the 3 pseudo operations in Taquito wallet API.

Implementation Details

Stake, unstake, and finalize_unstake are all considered 'pseudo operations' because they are essentially an extension of the existing transaction operation.

Refer to this document for further details on what that means: https://hackmd.io/@dsawali/H1_vK4t33

Implement a method wrapper in wallet API similar to increasePaidStorage, etc.

The method wrappers should be callable via the Wallet API as such:

await Tezos.wallet.stake(...);

await Tezos.wallet.unstake(...);

await Tezos.wallet.finalizeUnstake(...);

Testing

Write appropriate unit and integration tests. This will be part of the ticket's acceptance criteria.

@dsawali dsawali added enhancement New feature or request wallet Paris labels Apr 16, 2024
@dsawali dsawali added this to the v20 milestone Apr 16, 2024
@hui-an-yang hui-an-yang self-assigned this Apr 24, 2024
@hui-an-yang hui-an-yang linked a pull request Apr 24, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Paris wallet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants