Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the usage of OperationEmitter class in RpcTzProvider #2430

Closed
dsawali opened this issue Apr 11, 2023 · 1 comment
Closed

Replace the usage of OperationEmitter class in RpcTzProvider #2430

dsawali opened this issue Apr 11, 2023 · 1 comment
Labels
ga_release Work to be done so we can remove the beta dsignation
Milestone
v16.2

Comments

@dsawali
Copy link
Contributor

dsawali commented Apr 11, 2023

The OperationEmitter class is being extended by a number of Providers and does many things outside of it's intended scope. Refactor the usage of Operation Emitter in RpcTzProvider and leverage PrepareProvider where necessary.

Possible approaches:

  • Replace OperationEmitter class with a Provider parent class for these child providers to give basic access to Context
  • Leverage the usage of PrepareProvider in relevant parts of the child providers
@dsawali dsawali changed the title Repalce the usage of OperationEmitter class in RpcTzProvider Replace the usage of OperationEmitter class in RpcTzProvider Apr 11, 2023
@dsawali dsawali mentioned this issue Apr 11, 2023
Closed
4 tasks
@Innkst Innkst added the ga_release Work to be done so we can remove the beta dsignation label Apr 12, 2023
@Innkst Innkst added this to the v16.2 milestone Apr 12, 2023
@dsawali
Copy link
Contributor Author

dsawali commented Apr 12, 2023

Hey team! Please add your planning poker estimate with Zenhub @AlirezaHaghshenas @hui-an-yang @zainen

@Innkst Innkst closed this as completed Jun 1, 2023
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
Taquito Dev
Status: Done
Milestone
v16.2
Development

No branches or pull requests
2 participants
@dsawali @Innkst