Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to rxjs version 7.8.1 #2261

Closed
sirrocco opened this issue Jan 2, 2023 · 5 comments · Fixed by #2535
Closed

Upgrading to rxjs version 7.8.1 #2261

sirrocco opened this issue Jan 2, 2023 · 5 comments · Fixed by #2535
Assignees
Labels
8 house keeping Chores related to keeping a clean codebase
Milestone

Comments

@sirrocco
Copy link

sirrocco commented Jan 2, 2023

Description
RxJS V7 is out for a couple of years now and 8 is coming soon-ish - would you consider upgrading to it?

It's blocking the upgrade of other libraries.

Thank you.

Acceptance criteria:

  • Play with an upgrade in a branch
  • Explore if we can avoid the TS upgrade. The idea is to not upgrade TS, but upgrade rxjs to the highest version we have. Upgrading with TS at the same time is more risky, so if we can upgrade one and then another, it would be better and easier to downgrade if required.
    • discuss with the team if there is any TS dependencies
@sirrocco sirrocco added the bug Something isn't working label Jan 2, 2023
@sirrocco
Copy link
Author

sirrocco commented Jan 2, 2023

More of a feature request I guess .. not a bug - sorry about that.

@Innkst Innkst added house keeping Chores related to keeping a clean codebase and removed bug Something isn't working labels Jan 5, 2023
@Innkst
Copy link
Contributor

Innkst commented Jan 5, 2023

Thank you for this request. We need to assess the impact of this change on our code base and users' apps and then decided on the timing.

@Innkst Innkst added this to the v16.1 milestone Jan 5, 2023
@Innkst Innkst modified the milestones: v16.1, v16.2 Mar 11, 2023
@Innkst Innkst modified the milestones: v16.2, v17.1 Apr 15, 2023
@dsawali dsawali added the 3 label Jun 7, 2023
@dsawali dsawali self-assigned this Jun 13, 2023
@dsawali dsawali added 5 8 and removed 3 5 labels Jun 14, 2023
@dsawali
Copy link
Contributor

dsawali commented Jun 20, 2023

Updating RxJS to version 7.8.1 posed a few complications that I'm currently still working on. A few things to note:

  • It needs TS version 4.2.x. We are currently at 4.1.5, so updating will take time to refactor the necessary changes for Taquito to be compatible with TS 4.2.4
  • rx-sandbox library that we've been using to unit test RxJS observables doesn't seem like it supports the current version of RxJS we're adopting (7.8.1). We need to refactor and rewrite tests that rely on the rx-sandbox library that is no longer maintained
  • Some types will need updating to accommodate for new typechecks and assertions in the newer TS version

no significant blockers, just updating ticket for context

@dsawali
Copy link
Contributor

dsawali commented Jun 23, 2023

Hello @sirrocco, we're currently looking into upgrading RxJS versions to 7.8.1.

Would you mind sharing what kind of libraries were blocked by RxJS 6? Thanks

@Innkst Innkst changed the title Consider upgrading to rxjs version 7 Upgrading to rxjs version 7 Jul 6, 2023
@Innkst
Copy link
Contributor

Innkst commented Jul 6, 2023

Quick recap for the purpose of this ticket:

  • updated RxJS version from v6.x to v7.8.1
  • updated TS version for the @taquito/taquito package (and the parent package) from 4.1.5 to 4.2.4

@Innkst Innkst changed the title Upgrading to rxjs version 7 Upgrading to rxjs version 7.8.1 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 house keeping Chores related to keeping a clean codebase
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants