This repository has been archived by the owner on May 2, 2023. It is now read-only.
feat(select): (almost) green diff with ECL - TWIG-240 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
added
the
pr: review needed
papegaill
added
pr: under review
and removed
pr: review needed
papegaill
suggested changes
Jan 27, 2020
| @@ -36,11 +36,10 @@ storiesOf('Components/Forms/Select', module) | |||
| optional_text: text('Optional text', '(optional)'), | |||
| width: inputWidthSelect, | |||
| id: 'example-id', | |||
There was a problem hiding this comment.
necessary to set and example id here?
There was a problem hiding this comment.
Right, but more than that i saw that we were not using the data from the local folder but still the specs, i improved the story file, now it should be fine ;)
planctus
added
pr: review needed
papegaill
added
pr: under review
and removed
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The reason why the diff is not perfectly "green" is that the ECL react component is missing the required attribute when the field is required.
A ticket has been created to handle this on the ECL side:
https://webgate.ec.europa.eu/CITnet/jira/browse/FRONT-11
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)