-
Notifications
You must be signed in to change notification settings - Fork 5
fix(breadcrumb): component review - TWIG-205 #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Joosthe, i think we talked about this, the idea in general is that if it's possible, we move what we might have been doing in a story file to pass some data to the component, to the specs (the adapter in this case), so that also when the component is rendered programmatically (js and php) we get the same rendering.
In this case for instance the diff is still showing differences that we can easily and properly fix by applying those information in the adapter instead of doing it in the story.
If there's still lack of clarity about this, please ask about any doubt you may have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oke i have changed the values will now be loade from the specs
@Joosthe , i pushed a commit to make the diff entirely green, it also contains a simplification of the tests (it all comes from the specs right now), take a look and see if it's good for you ;) |
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)