This repository has been archived by the owner on May 2, 2023. It is now read-only.
fix(button): Setting data-ecl-icon on the icon when used in a button - TWIG-199 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joosthe
added
the
pr: review needed
Joosthe
changed the title
planctus
added
pr: under review
and removed
pr: review needed
planctus
reviewed
Jan 17, 2020
src/ec/packages/ec-component-accordion/__snapshots__/accordion.test.js.snap
Outdated
Show resolved
Hide resolved
| </h{{ _item.level|default(3) }}> | ||
| <div | ||
| class="ecl-accordion__content" | ||
| hidden | ||
| id="{{ _item.id }}" | ||
| id="{{ _item.id }}-content" |
There was a problem hiding this comment.
Not really sure why this is done like this in ECL, might be that this a way to "target" the old accordion (this is the deprecated one).
…ropa/ecl-twig into twig-199-improve-accordion
Joosthe
added
the
pr: review needed
…ropa/ecl-twig into twig-199-improve-accordion
planctus
changed the title
planctus
suggested changes
Jan 20, 2020
planctus
added
pr: modification needed
and removed
pr: review needed
planctus
reviewed
Jan 20, 2020
Joosthe
added
pr: review needed
planctus
approved these changes
Jan 22, 2020
planctus
removed
the
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)