This repository has been archived by the owner on May 2, 2023. It is now read-only.
fix(storybook): add babel-polyfill to preview-head for IE Edge - TWIG-220 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaill
added
the
pr: review needed
There was a problem hiding this comment.
Checked and it works fine.
Please note that this package has been deprecated (as noted in babel docs) and it has a newer version which also works fine.
This preview template is not something to deliver in the final product of the repo (like the twig templates) so it looks ok to me to have the script added in the head of the preview.
Just a note, I gave polyfill.io a try with a selected es5, es6, es7 + Symbol features. Didn't work as the babel/polyfill so I don't have a better idea or alternative to the used lib.
planctus
added
pr: under review
and removed
pr: review needed
planctus
reviewed
Jan 20, 2020
|
@kalinchernev, @planctus PR updated, I tried to not use @babel/polyfill as mention in this article, but without success https://www.thebasement.be/updating-to-babel-7.4/ |
papegaill
added
pr: review needed
kalinchernev
approved these changes
Jan 22, 2020
kalinchernev
removed
pr: questions
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)