This repository has been archived by the owner on May 2, 2023. It is now read-only.
fix(deps): Updating some deps, using resolutions block to get rid of duplicated version of istanbul-reports #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The warning is about handlebars < 4.3.0, the investigation revealed that is the package "istanbul-reports" (as part of the jest dependencies) that was depending on an old version of handlebars.
together with some updates in the libraries a "resolutions" block has been added in the package.json, other attempts to upgrade istanbul-reports resulted in a duplicated version of the package that i could not ged rid of (using yarn-deduplicate or yarn-dedupe).
I don't think there is a way to "test" this on github to see whether the warning would go away, anyway you can look at the yarn.lock (might be needed to remove it, first) for handlebars, no older version than 4.3.0 should be in use, basically.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)