Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(deps): Updating some deps, using resolutions block to get rid of duplicated version of istanbul-reports #276

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Jan 7, 2020

PR description

The warning is about handlebars < 4.3.0, the investigation revealed that is the package "istanbul-reports" (as part of the jest dependencies) that was depending on an old version of handlebars.
together with some updates in the libraries a "resolutions" block has been added in the package.json, other attempts to upgrade istanbul-reports resulted in a duplicated version of the package that i could not ged rid of (using yarn-deduplicate or yarn-dedupe).
I don't think there is a way to "test" this on github to see whether the warning would go away, anyway you can look at the yarn.lock (might be needed to remove it, first) for handlebars, no older version than 4.3.0 should be in use, basically.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

…duplicated version of istanbul-reports - TWIG-197
@planctus planctus added the pr: review needed Use this label to show that your PR needs to be review label Jan 7, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Jan 8, 2020
@papegaill papegaill merged commit cf73fad into master Jan 8, 2020
@papegaill papegaill deleted the TWIG-197 branch January 8, 2020 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants