This repository has been archived by the owner on May 2, 2023. It is now read-only.
fix(button): Simplify markup - TWIG-98 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papegaill
added
the
pr: review needed
papegaill
changed the title
planctus
added
pr: under review
and removed
pr: review needed
planctus
reviewed
Oct 29, 2019
There was a problem hiding this comment.
Just a small inconsistency regarding the story, would you also update the package.json of the component, it's true that most likely nothing has changed in the ecl specs, for instance, but their version should reflect the status of the component, also the version of the component can be updated, just to mark the change.
papegaill
added
pr: review needed
serotonine
added
pr: under review
and removed
pr: review needed
planctus
added
pr: review needed
planctus
approved these changes
Nov 5, 2019
planctus
removed
the
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)