Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Twig template checkstyle #145

Closed
drupol opened this issue Sep 18, 2019 · 3 comments
Closed

Twig template checkstyle #145

drupol opened this issue Sep 18, 2019 · 3 comments

Comments

@drupol
Copy link

drupol commented Sep 18, 2019

Hi,

I discovered this package recently: friendsoftwig/twigcs and I think it might be useful for you guys.

Basically it's a codestyle checker for .twig files based on an official ruleset.

Here's the log of the result when I run this against the repo: https://pastebin.com/kpmMjpNX

I noticed that there are some false positive, but overal it gives you some hints on how to improve and standardize the .twig files.

@planctus
Copy link
Contributor

Thanks @drupol, think this a very hot topic, we need to improve the overall quality of the templates, as this tool shows we have many inconsistencies, glitches, issues of different type. Mind just the fact that we write TWIG 1, we'll come out with something on this soon.

@drupol
Copy link
Author

drupol commented Sep 19, 2019

Hi,

Code style and check style is always a hot topic... I reaaaally know what you're talking about.
I was just sharing that tool that I didn't know and that I found really cool to align developers, without spending time discussion how things should be written.

That said, if you'll come out with something soon, I can't wait to see :-)

@drupol
Copy link
Author

drupol commented Oct 1, 2019

See #162

@drupol drupol closed this as completed Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants