Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

fix(language-list-overlay): Missing </div> - TWIG-19 #116

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Conversation

serotonine
Copy link
Contributor

@serotonine serotonine commented Aug 22, 2019

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus self-assigned this Sep 9, 2019
Copy link
Contributor

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see that there was a missing closing that there, but i would have expected also the "snapshot" to change once this fix was applied, instead no changes, and it doesn't even change if we add random code at the end of the template...

@planctus planctus merged commit b176b51 into v2.9-dev Sep 9, 2019
@planctus planctus deleted the TWIG-19 branch September 10, 2019 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants