This repository has been archived by the owner on May 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: implement inpage navigation - INNO-1555 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haringsrob
changed the title
wip: INNO-1555 Inpage navigation
feat: INNO-1555 Inpage navigation
Jun 24, 2019
haringsrob
added
the
pr: review needed
Use this label to show that your PR needs to be review
label
Jun 24, 2019
haringsrob
changed the title
feat: INNO-1555 Inpage navigation
feat: Inpage navigation - INNO-1555
Jun 24, 2019
yhuard
added
pr: under review
and removed
pr: review needed
Use this label to show that your PR needs to be review
labels
Jun 24, 2019
yhuard
changed the title
feat: Inpage navigation - INNO-1555
feat: implement inpage navigation - INNO-1555
Jun 24, 2019
yhuard
suggested changes
Jun 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted some small things to change here and there but overall it's great!
Is it me or https://deploy-preview-104--ecl-twig.netlify.com/ec/?path=/story/components-inpage-navigation--default doesn't feel smooth? When I'm scrolling, I have the impression that it's lagging...
src/ec/packages/ec-component-inpage-navigation/inpage-navigation.html.twig
Outdated
Show resolved
Hide resolved
src/ec/packages/ec-component-inpage-navigation/inpage-navigation.html.twig
Outdated
Show resolved
Hide resolved
src/ec/packages/ec-component-inpage-navigation/inpage-navigation.story.js
Outdated
Show resolved
Hide resolved
I made the changes requested. |
haringsrob
added
pr: review needed
Use this label to show that your PR needs to be review
and removed
pr: wip
Mark the PR as WIP
labels
Jun 24, 2019
I dont really notice any "lag" it does skip items when you scroll fast. |
yhuard
added
pr: under review
and removed
pr: review needed
Use this label to show that your PR needs to be review
labels
Jun 25, 2019
yhuard
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)