This repository has been archived by the owner on May 2, 2023. It is now read-only.
feat(accordion): add accordion 2 - INNO-1548 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
added
the
pr: review needed
yhuard
added
pr: under review
and removed
pr: review needed
yhuard
suggested changes
Jun 20, 2019
emeryro
added
the
pr: review needed
yhuard
added
pr: under review
and removed
pr: review needed
…opa/ecl-twig into feat/accordion2-INNO-1548
yhuard
suggested changes
Jun 25, 2019
| size: "m" | ||
| }, | ||
| extra_classes: 'ecl-accordion2__toggle-icon', | ||
| extra_attributes: [{ name: "data-ecl-accordion2-icon", value: "true" }] |
There was a problem hiding this comment.
it would be great if we didn't have to pass a value to extra attributes (unnecessary), but this change of logic would need to be applied to every components... unless we create some global macros
what do you think?
There was a problem hiding this comment.
actually, it does seems to work by putting only a name (without changing the logic). I'll update it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add second version of accordion (ECL >= 2.6.0)