Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Project collections don't load projects #1031

Open
Dgojsic opened this issue Jan 13, 2025 · 5 comments
Open

New Project collections don't load projects #1031

Dgojsic opened this issue Jan 13, 2025 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Dgojsic
Copy link
Collaborator

Dgojsic commented Jan 13, 2025

For the new PSLF and C4C collections, when filter is set, displays no projects, but loads in the correct number of projects that are supposed to be there. Other collections work as intended.
image

@madewild madewild added this to the v3.2 milestone Jan 13, 2025
@madewild madewild added the bug Something isn't working label Jan 13, 2025
@madewild
Copy link
Member

@DiaZork is this something you have to hardcode in the backend?
FYI @raphdom @ntorbev

@madewild
Copy link
Member

@DiaZork
Copy link
Collaborator

DiaZork commented Jan 13, 2025

I've notice it too 5 min ago and I've just pushed a fix.
The list of collection that appear in the filter for the project collection is hardcoded.
But the problem was that because we order by budget*readability it was expecting a budget but there is no budget on those projects so i've put the budget as OPTIONAL and now it should be working

And btw does this filter should go to the index release ? If yes it mean that we are going to need to make an updtae of the backend too to add this project collection and the fix for the OPTIONAL budget (in total it's something like 5 line of code that changed for that)

@Dgojsic
Copy link
Collaborator Author

Dgojsic commented Jan 13, 2025

Thanks @DiaZork for addressing! And yes, these two collections are basically the reason why we are doing the index release in the first place, so if you could add that to the backend, would be great!

@Dgojsic
Copy link
Collaborator Author

Dgojsic commented Jan 13, 2025

Also, @DiaZork, do not forget to make it filterable on the map. I just checked on the one on dev, and it just spins forever if you filter for those specific collections, just make sure it works with the map version we aim to do the index update with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants