Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic-Module-Name #191

Open
jbb01 opened this issue Dec 21, 2023 · 3 comments
Open

Automatic-Module-Name #191

jbb01 opened this issue Dec 21, 2023 · 3 comments

Comments

@jbb01
Copy link

jbb01 commented Dec 21, 2023

For better compatibility with the JPMS (Java Platform Module System) it would be desirable to either have an Automatic-Module-Name defined in the META-INF file or a module-info.java (possibly as a multi-release JAR).

@ebourg
Copy link
Owner

ebourg commented Dec 21, 2023

I'm not sure that's that easy. The net.jsign package is shared among different modules and that's not allowed, so supporting JPMS required some code reorganisation first.

What would Jsign JPMS compatibility fix for you?

@jbb01
Copy link
Author

jbb01 commented Dec 22, 2023

Thanks for the quick reply.

As far as I'm concerned, it looks like the package conflicts could easily be resolved by moving each of the plugins to subpackages, i.e. the maven plugin would be located in net.jsign.maven or something like that (assuming there isn't any package-private stuff).

In my case I am trying to build a modularized application depending on jsign-core and I'd prefer not having to depend on a module that's name is dependend on the JAR-file name.

I can see that modularization for the maven, gradle and ant plugin might not be necessary at all.

@ebourg
Copy link
Owner

ebourg commented Dec 22, 2023

assuming there isn't any package-private stuff

That's the issue, many implementation details are hidden behind package private classes and methods.

I can see that modularization for the maven, gradle and ant plugin might not be necessary at all

So JPMS support for jsign-core only, why not. Do you want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants