Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for diagnostic requests on server #374

Closed
3 tasks done
ebkalderon opened this issue Feb 28, 2023 · 6 comments · Fixed by #396 or #397
Closed
3 tasks done

Implement support for diagnostic requests on server #374

ebkalderon opened this issue Feb 28, 2023 · 6 comments · Fixed by #396 or #397
Assignees
@ebkalderon
Labels
enhancement New feature or request

Comments

@ebkalderon
Copy link
Owner

ebkalderon commented Feb 28, 2023 •
edited
Loading

The LanguageServer trait is missing the following requests:

  • textDocument/diagnostic
  • workspace/diagnostic

The Client struct is also missing the following requests:

  • workspace/diagnostic/refresh

These request types were added in LSP 3.17.0, but lsp-types unfortunately doesn't support them. This should have landed in lsp-types 0.94.0, but was missed in gluon-lang/lsp-types#255. I've opened gluon-lang/lsp-types#258 to address this omission.
@ebkalderon ebkalderon added the enhancement New feature or request label Feb 28, 2023
@ebkalderon ebkalderon self-assigned this Feb 28, 2023
@ebkalderon ebkalderon mentioned this issue Feb 28, 2023
Merged
@ebkalderon ebkalderon changed the title Add support for diagnostic requests on server Implement support for diagnostic requests on server Mar 8, 2023
@ebkalderon
Copy link
Owner Author

Unassigning myself as this ticket is blocked on gluon-lang/lsp-types#258 currently.

@ebkalderon ebkalderon removed their assignment Mar 10, 2023
@meetmangukiya
Copy link

does there exist any branch of tower-lsp with implementation utilizing gluon-lang/lsp-types#258?

@ebkalderon
Copy link
Owner Author

@meetmangukiya Not at the moment, sadly. It should be pretty trivial to add after the PR is merged, though!

@ebkalderon
Copy link
Owner Author

Upstream PR was only just merged! 🎉 A maintenance release of tower-lsp containing the changes should come shortly.

@ebkalderon ebkalderon mentioned this issue Aug 11, 2023
Merged
@ebkalderon ebkalderon self-assigned this Aug 11, 2023
@ebkalderon ebkalderon mentioned this issue Aug 11, 2023
Merged
@ebkalderon
Copy link
Owner Author

@meetmangukiya Alright, tower-lsp 0.20.0 and tower-lsp-macros 0.9.0 have been released to crates.io. This release includes full support for diagnostic requests. 🚀

@meetmangukiya
Copy link

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebkalderon ebkalderon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@ebkalderon @meetmangukiya