Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inlineValue method and Inlay Hint Request #352

Closed
OceanBelongsToMe opened this issue Sep 18, 2022 · 4 comments · Fixed by #375 or #376
Closed

support inlineValue method and Inlay Hint Request #352

OceanBelongsToMe opened this issue Sep 18, 2022 · 4 comments · Fixed by #375 or #376
Assignees
Labels
enhancement New feature or request

Comments

@OceanBelongsToMe
Copy link

No description provided.

@OceanBelongsToMe OceanBelongsToMe changed the title support inlineValue method support inlineValue method and Inlay Hint Request Sep 18, 2022
@ebkalderon ebkalderon added the enhancement New feature or request label Jan 4, 2023
@ebkalderon
Copy link
Owner

Seems like a big omission! These should both be added for the next major release.

@ebkalderon
Copy link
Owner

ebkalderon commented Jan 19, 2023

Hmm, it seems that lsp-types still marks inlay hint requests as proposed despite being officially adopted into the spec (gluon-lang/lsp-types#251) and also lacks support for inline values entirely (gluon-lang/lsp-types#252). I'll have to submit a pull request against lsp-types to have this remedied before starting work on integrating this into tower-lsp.

@ebkalderon
Copy link
Owner

ebkalderon commented Jan 19, 2023

I've opened gluon-lang/lsp-types#255 to add support for this, as well as other missing functionality (except for notebook support, which seems is already being worked on by someone else).

EDIT: The pull request has finally been merged upstream! It should now be possible to update tower-lsp to lsp-types 0.94.0 and cut a new release supporting LSP 3.17 to Crates.io.

@ebkalderon
Copy link
Owner

Updated lsp-types to 0.94.0 in #367. Will update the LanguageServer trait to enable 3.17 features into tower-lsp soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants