Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to set width? (or responsive to container width)? #48

Open
sillitoe opened this issue Feb 7, 2017 · 3 comments
Open

allow users to set width? (or responsive to container width)? #48

sillitoe opened this issue Feb 7, 2017 · 3 comments

Comments

@sillitoe
Copy link

sillitoe commented Feb 7, 2017

Thanks for all the work on this project - especially for allowing the flexibility for custom data sources.

I couldn't find anything in the docs about resizing - looks like the width is hard-coded (to 760px).

Would it be possible to specify width on init (or allow the component to stretch to the container)?

In fact, it might be even nicer to allow for a responsive width based on the container element (with redraw on page resize)?

Best,

Ian

@ljgarcia
Copy link
Contributor

ljgarcia commented Feb 8, 2017

We did think about it at some point but decided against it. A responsive width could leave us with not enough room for labels and features so we will probably not go for it. Adding the width as an instantiation option could work, with a minimum fixed. Will take a look. Would something like this work for you?

You mentioned the flexibility for custom data sources, we would be interested in learning more about your experience with it.

Regards,

@sillitoe
Copy link
Author

sillitoe commented Feb 8, 2017

Yes thanks - explicitly setting the width on init would be good.

I suppose it would be possible for the user to manually recreate the app on resize if they really wanted (though less efficient than providing the ability for an internal width reset and redraw).

My plan is to add an alternative set of domain annotations as a custom track - the docs look good, I'll let you know if I get stuck.

Also looking at customising the CSS a little - I can refactor any changes into a "theme" file to show how people can provide their own tweaks if that sounds useful.

@ljgarcia
Copy link
Contributor

ljgarcia commented Feb 9, 2017

The CSS theme sounds nice, thanks. We will take a look to the width option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants